[AKS] az aks machine list/az aks machine show: Add zones to cli output#31668
[AKS] az aks machine list/az aks machine show: Add zones to cli output#31668
Conversation
skuchipudi295
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @skuchipudi295, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
There was a problem hiding this comment.
Pull Request Overview
This PR adds availability zones to the az aks machine list and az aks machine show commands by updating CLI help examples and table formatting.
- Updated help examples to mention “Availability Zones” for both list and show commands
- Extended the table formatter to include a new
zonesfield in the output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/_help.py | Fixed help text examples to reference zones correctly |
| src/azure-cli/azure/cli/command_modules/acs/_format.py | Added zones field to the table formatter for machine output |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/acs/_format.py:51
- The new zones formatting logic is added here but there are no corresponding tests; consider adding unit tests for zonal and non-zonal entries.
zones = ', '.join(part.strip() for part in entry["zones"] if entry["zones"].strip())
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31668 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
There's another failure in the CI check
E jmespath.exceptions.ParseError: Expecting: ['quoted_identifier', 'unquoted_identifier'], got: rbrace: Parse error at column 96, token "}" (RBRACE), for expression:
E "{
E name: name,
E ip: ip,
E zones: zones,
E }"
E ^
|
please fix style issue
|
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_machine_cmds
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
failed with following error
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
I suppose this is not a breaking change, please remove History Notes |
|
Re-queued live test |
|
Please note that there's a code freeze until the latest version of azure-cli is officially released |
skuchipudi295
changed the title
skuchipudi295
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
optimized the history notes: |
Related command
az aks machine show
az aks machine list
Description
Adding zones to Machine api GA.
Testing Guide
az aks machine list should show node name, IP info {name, ipv4, ipv6 addresses, zones(if zonal)} for all nodes in an agentpool. az aks machine show should show specific machine info {name, ipv4, ipv6 addresses, zones(if zonal)} in an agentpool
History Notes
[AKS]
az aks machine show/list: Add zones to table outputThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.