{Test} Update the response processing in EmailAddressReplacer#31677
Merged
{Test} Update the response processing in EmailAddressReplacer#31677
Conversation
️✔️AzureCLI-FullTest
|
FumingZhang
requested review from
bebound,
jiasli,
jsntcy,
kairu-ms and
wangzelin007
as code owners
|
Hi @FumingZhang, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the conversion process of bytes to strings to handle binary files that cannot be decoded in UTF-8. It adds a try/except block in the _byte_to_str function and includes an additional type check in process_response to ensure only strings are manipulated.
Comment on lines
+56
to
+57
| except UnicodeDecodeError: | ||
| pass |
There was a problem hiding this comment.
[nitpick] Consider logging the UnicodeDecodeError in the _byte_to_str function (inside the try/except block) to facilitate debugging of unexpected binary content issues.
Suggested change
| except UnicodeDecodeError: | |
| pass | |
| except UnicodeDecodeError as e: | |
| import logging | |
| logging.error(f"Failed to decode bytes: {byte_or_str}. Error: {e}") |
FumingZhang
changed the title
Member
Author
|
@jiasli, @evelyn-ys could you please help take a look? |
evelyn-ys
approved these changes
Jun 20, 2025
bebound
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
{Test} Update the response processing in EmailAddressReplacer. In some scenario tests, we may download some binary files, which cannot be converted to utf8-encoded strings, resulting in errors. Related to #31262.
The following is a sample error when running test case test_aks_install_kubectl, which downloads the binary kubectl
https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=127765187&view=logs&j=b162b355-d59d-5864-ce0f-0a70f12dd28b&t=dc59ccd1-231f-538b-777f-33a592c7ca57&l=2729
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.