Merged
Conversation
FumingZhang
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @FumingZhang, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates several AKS test cases to reflect changes in default configurations and command parameters. Key changes include updating the default value for maxPods from 110 to 250, removing tests for the HTTP application routing addon, and adding the new '--aks-custom-headers' parameter in multiple command invocations.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py | Updates maxPods values, removes http routing addon tests, adjusts service mesh command, and adds custom headers and explicit os disk type where necessary |
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_default.yaml | Updates expected maxPods value to 250 in the recorded responses |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py:853
- The removal of the HTTP application routing addon test case may reduce coverage of add-on features. Please verify that this removal is intentional and that test coverage for add-on functionality is maintained elsewhere.
StringContainCheck(upgrade_version)
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py:3883
- The deletion of the HTTP application routing addon test in this block suggests a reduction in coverage for the add-on feature. Ensure that this change is aligned with the intended test strategy.
self.cmd('aks show -g {resource_group} -n {name}', expect_failure=True)
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
force-pushed
the
fuming/aks-test-0619
branch
from
0aeda23 to
ce1619c
Compare
zhoxing-ms
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
{AKS} Fix several test cases
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.