{Network} az network virtual appliance: GA release#31680
Merged
Conversation
Jing-song
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR promotes the Azure CLI network virtual-appliance commands from preview to GA by removing the is_preview=True flag from all relevant command and command-group registrations.
- Removed the
is_previewparameter forsku,site, and corenetwork virtual-appliancecommands. - Ensured delete commands retain their
confirmationargument.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/.../network/virtual_appliance/sku/_show.py | Dropped is_preview=True from sku show |
| src/.../network/virtual_appliance/sku/_list.py | Dropped is_preview=True from sku list |
| src/.../network/virtual_appliance/sku/__cmd_group.py | Dropped is_preview=True from sku group |
| src/.../network/virtual_appliance/site/_update.py | Dropped is_preview=True from site update |
| src/.../network/virtual_appliance/site/_show.py | Dropped is_preview=True from site show |
| src/.../network/virtual_appliance/site/_list.py | Dropped is_preview=True from site list |
| src/.../network/virtual_appliance/site/_delete.py | Removed preview flag; kept confirmation |
| src/.../network/virtual_appliance/site/_create.py | Dropped is_preview=True from site create |
| src/.../network/virtual_appliance/site/__cmd_group.py | Dropped is_preview=True from site group |
| src/.../network/virtual_appliance/_update.py | Dropped is_preview=True from update |
| src/.../network/virtual_appliance/_show.py | Dropped is_preview=True from show |
| src/.../network/virtual_appliance/_list.py | Dropped is_preview=True from list |
| src/.../network/virtual_appliance/_delete.py | Removed preview flag; kept confirmation |
| src/.../network/virtual_appliance/_create.py | Dropped is_preview=True from create |
Member
|
plz provide the changes in Azure/aaz. |
Contributor
Author
|
necusjz
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
close #31666
aaz: Azure/aaz#787
All of the networkVirtualAppliance commands listed here: https://learn.microsoft.com/en-us/cli/azure/network/virtual-appliance?view=azure-cli-latest have been GA for a while now. Remove the "preview" tag on them.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.