{Signalr} Mask secrets for signalr tests#31681
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to clean up the repository by masking secrets in the SignalR test recording file so that any sensitive information is not committed.
- Secrets in connection strings are replaced with placeholder asterisks.
- The updates occur in two sections of the YAML file corresponding to key regeneration and listing operations.
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/signalr/tests/latest/recordings/test_signalr_commands.yaml:1985
- Ensure that the masked access key lengths are consistent with any test expectations. If tests verify key formatting or length, update them accordingly to accommodate the new placeholder values.
string: '{"primaryKey":"***","secondaryKey":"***","primaryConnectionString":"Endpoint=https://signalr000002.service.signalr.net;AccessKey=************************************************************************************;Version=1.0;","secondaryConnectionString":"Endpoint=https://signalr000002.service.signalr.net;AccessKey=************************************************************************************;Version=1.0;"}'
src/azure-cli/azure/cli/command_modules/signalr/tests/latest/recordings/test_signalr_commands.yaml:2039
- Verify that the new masked key format does not break any assertions in the tests that rely on a specific key pattern or length.
string: '{"primaryKey":"***","secondaryKey":"***","primaryConnectionString":"Endpoint=https://signalr000002.service.signalr.net;AccessKey=************************************************************************************;Version=1.0;","secondaryConnectionString":"Endpoint=https://signalr000002.service.signalr.net;AccessKey=************************************************************************************;Version=1.0;"}'
kairu-ms
approved these changes
Jun 20, 2025
yonzhan
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
The secrets in signalr test recording file should already be invalid. This PR is just to make repo clean
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.