[Containerapp] Fix #31480: az containerapp revision copy: Only return containerapp does not exist when got 404#31689
Merged
zhoxing-ms merged 1 commit intodevfrom Jun 23, 2025
Merged
Conversation
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the error handling for the "az containerapp revision copy" command so that only a 404 error will result in a "containerapp does not exist" message.
- Updated imports to include handle_non_404_status_code_exception
- Replaced a generic exception catch with a more explicit exception handler to delegate non-404 status code errors
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
ebencarek,
jsntcy,
ruslany,
sanchitmehta and
vinisoto
Greedygre
changed the title
az containerapp revision copy: Only return containerapp does not exist when got 404az containerapp revision copy: Only return containerapp does not exist when got 404
microsoft-github-policy-service
bot
requested review from
chinadragon0515,
jijohn14,
pagariyaalok,
torosent and
vturecek
Greedygre
changed the title
az containerapp revision copy: Only return containerapp does not exist when got 404az containerapp revision copy: Only return containerapp does not exist when got 404
Greedygre
changed the title
az containerapp revision copy: Only return containerapp does not exist when got 404az containerapp revision copy: Only return containerapp does not exist when got 404
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Greedygre
changed the title
az containerapp revision copy: Only return containerapp does not exist when got 404az containerapp revision copy: Only return containerapp does not exist when got 404
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
Hi @zhoxing-ms |
zhoxing-ms
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp revision copyFix: #31480
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.