Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR enables replica operations for elastic cluster operations by updating the validation logic in the PostgreSQL flexible-server commands.
- Added ValidationError to handle elastic cluster-specific validation errors.
- Removed the direct citus cluster check in replica creation and replaced it with elastic cluster–specific validations in the replica promotion command.
Comments suppressed due to low confidence (3)
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py:599
- [nitpick] The removal of the citus cluster validation call for replica creation should be accompanied by an inline comment explaining the rationale for its removal to aid in future maintainability.
source_server_id_parts = parse_resource_id(source_server_id)
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py:826
- [nitpick] Consider adding an inline comment clarifying why the standalone promotion mode is disallowed for elastic clusters to improve readability and maintainability of the validation logic.
if promote_mode.lower() == 'standalone':
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py:828
- [nitpick] Consider adding an inline comment explaining why the planned promotion option is disallowed for elastic clusters to enhance clarity for future maintainers.
if promote_option.lower() == 'planned':
|
@evelyn-ys trying to rerun one of the tests locally and getting failure: ERROR cli.azure.cli.core.azclierror:azlogging.py:212 'VCRHTTPResponse' object has no attribute 'version_string' Could you help share how to resolve this? |
|
@nasc17 It seems like your local development env issue. Maybe check the VCR version used? Or try |
|
@mattboentoro Pls fix CI failure |
…ble-2' into nasc/byokTestAttempt718
…mattboentoro/cof-replica-enable-2
…ble-2' into nasc/byokTestAttempt718
BYOK test fix
|
@evelyn-ys test passed already, do you mind reviewing this PR? |
Related command
az postgres flexible-server replica create
az postgres flexible-server replica promote
Description
Enable replica operations for elastic cluster operations
Testing Guide
Manual testing
History Notes
[RDBMS]
az postgres flexible-server replica create/promote: Enable replica operations for elastic cluster operationsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.