Merged
Conversation
FumingZhang
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes an unnecessary check from the default AKS creation test and completely removes the failing test case for node pool abort operations.
- Removed the osDiskSizeGb check from test_aks_create_default.
- Deleted the test_aks_nodepool_abort test and its corresponding recorded interactions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py | Removed the osDiskSizeGb check and the entire test_aks_nodepool_abort method to prevent false failures. |
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_nodepool_abort.yaml | Removed the recordings associated with the deleted test case. |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py:5629
- The test_aks_nodepool_abort function has been removed as it was failing in live test mode. Please ensure that any dependencies or documentation referencing this deprecated test are updated accordingly.
self.cmd(show_cmd, checks=[self.check('provisioningState', 'Canceled')])
microsoft-github-policy-service
bot
added
Auto-Assign
yanzhudd
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
{AKS} Fix several test cases
test_aks_create_defaulttest_aks_nodepool_abortas it would always fail in live test modeTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.