Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appconfig feature delete | cmd appconfig feature delete added parameter tags |
||
| appconfig feature list | cmd appconfig feature list added parameter tags |
||
| appconfig feature set | cmd appconfig feature set added parameter tags |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
avanigupta,
jsntcy,
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
App Configuration
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for setting and filtering by tags for the feature commands (set, list, and delete) in the App Config module.
- Updated tests to cover tag filtering and edge cases (e.g. empty tag values, too many tags).
- Enhanced implementations in feature.py to accept a new tags parameter and propagated tag data in the feature models.
- Revised parameter definitions in _params.py and updated the FeatureFlag model to include tags.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_feature_commands.py | Added comprehensive tag filtering tests for feature set, list, and delete commands. |
| src/azure-cli/azure/cli/command_modules/appconfig/feature.py | Updated feature command functions to accept and handle tags. |
| src/azure-cli/azure/cli/command_modules/appconfig/_params.py | Added tags argument definitions and help messages for feature commands. |
| src/azure-cli/azure/cli/command_modules/appconfig/_featuremodels.py | Extended FeatureFlag model to support and serialize tags. |
| @@ -67,7 +68,6 @@ def set_feature(cmd, | |||
| raise exception | |||
|
|
|||
| # when creating a new Feature flag, these defaults will be used | |||
There was a problem hiding this comment.
Consider initializing tags to an empty dictionary (e.g. 'tags = {}') if not provided, to ensure that FeatureFlag objects consistently represent tags as a dictionary instead of null.
Contributor
|
Perhaps we should update |
Contributor
Author
Thats a good idea! I have added examples. |
albertofori
reviewed
Jul 23, 2025
albertofori
reviewed
Jul 23, 2025
albertofori
approved these changes
Jul 23, 2025
Co-authored-by: Albert Ofori <102393878+albertofori@users.noreply.github.com>
Co-authored-by: Albert Ofori <102393878+albertofori@users.noreply.github.com>
Collaborator
|
Please fix CI issues |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az app config feature set/list/delete: Support setting and filtering by tags for feature commandsaz appconfig feature set/list/delete: Support setting and filtering by tags for feature commands
yanzhudd
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig feature set
az appconfig feature list
az appconfig feature delete
Description
This PR adds support for setting and filtering by tags for the feature commands.
Testing Guide
History Notes
[App Config]
az appconfig feature list/delete/set: Support filtering by tagsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.