{AKS} fix test case when AGIC with Azure CNI Overlay#31713
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Jun 26, 2025
Merged
{AKS} fix test case when AGIC with Azure CNI Overlay#31713zhoxing-ms merged 2 commits intoAzure:devfrom
zhoxing-ms merged 2 commits intoAzure:devfrom
Conversation
robogatikov
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AKS command tests to use a valid App Gateway subnet CIDR (/26) when the ingress-appgw addon is enabled in an Azure CNI Overlay cluster.
- Changed the test command’s
--appgw-subnet-cidrfrom/16to/26 - Updated the expected
subnetCIDRassertion to/26
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
robogatikov
force-pushed
the
robogatikov/fix-test-agic-with-overlay
branch
from
16aee3e to
aebca81
Compare
FumingZhang
approved these changes
Jun 26, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Live test passed!
- test_aks_create_with_ingress_appgw_addon
zhoxing-ms
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks createDescription
When Ingress Appgateway Addon is enabled in Azure CNI Overlay cluster and
--uppgw-subnet-cidris specified on cluster create, the cidr should be shorter than /24.Testing Guide
az aks create --resource-group=<resource-group> --name=<cluster-name> --enable-managed-identity --enable-addons=ingress-appgw --appgw-subnet-cidr 10.232.0.0/26- note the app gateway subnet cidr is shorter than /24.History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.