{Auth} Do not show re-authentication message for service principal and managed identity#31745
Open
{Auth} Do not show re-authentication message for service principal and managed identity#31745
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the authentication error handler so that the interactive login recommendation is only shown when context arguments are provided (e.g., Cloud Shell) and is suppressed for service principal and managed identity failures.
- Initialize
recommendationtoNoneby default - Change the
elsebranch toelif kwargsso that the interactive login prompt only appears when kwargs are present
Comments suppressed due to low confidence (1)
src/azure-cli-core/azure/cli/core/auth/util.py:44
- Add a unit test for
aad_error_handlerwhen called with no kwargs to verify thatrecommendationremainsNonefor service principal and managed identity error paths.
recommendation = None
| if error_codes and 7000215 in error_codes: | ||
| recommendation = PASSWORD_CERTIFICATE_WARNING | ||
| else: | ||
| elif kwargs: |
There was a problem hiding this comment.
[nitpick] The elif kwargs condition may be unclear about which scenarios trigger the interactive prompt. Consider adding a comment or using explicit checks (e.g., if is_cloud_shell:) to clarify intent.
Suggested change
| elif kwargs: | |
| # If additional context (e.g., tenant or scopes) is provided in kwargs, suggest interactive authentication. | |
| elif 'tenant' in kwargs or 'scopes' in kwargs or 'claims_challenge' in kwargs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the re-authentication message is also shown for service principals:
and managed identity:
This is incorrect and meaningless.
This PR changes behavior so that the re-authentication message with a bare
az loginis not shown for service principal:or managed identity:
For Cloud Shell, we still show the re-authentication message as a fallback (explicit login) in case of failure:
azure-cli/src/azure-cli-core/azure/cli/core/auth/msal_credentials.py
Line 132 in 4177017