[DMS] az dms project create: Add breaking change warning#31759
Merged
[DMS] az dms project create: Add breaking change warning#31759
az dms project create: Add breaking change warning#31759Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a breaking change warning for the --location argument on the az dms project create command.
- Introduces a new module to register an argument deprecation
- Triggers a warning when users specify the deprecated
locationargument
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/dms/_breaking_change.py:7
- Consider specifying the
versionparameter inregister_argument_deprecateso users know when the--locationargument will be removed, e.g.,version='3.0.0'.
register_argument_deprecate('dms project create', argument='location')
src/azure-cli/azure/cli/command_modules/dms/_breaking_change.py:7
- Add a test case to verify that using
az dms project create --locationemits the expected deprecation warning.
register_argument_deprecate('dms project create', argument='location')
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
temandr
changed the title
az dms project create ...az dms project create ...
temandr
changed the title
az dms project create ...az dms project create ...: Add breaking change warning
temandr
changed the title
az dms project create ...: Add breaking change warningaz dms project create: Add breaking change warning
sergb213
approved these changes
Jul 8, 2025
kairu-ms
approved these changes
Jul 11, 2025
necusjz
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az dms project create ....Description
A warning note for #31465
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.