Skip to content

[rdbms] az postgresql flexible-server create: Handle failed IP address check #31834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 2 commits into from
Jul 28, 2025
Merged

[rdbms] az postgresql flexible-server create: Handle failed IP address check #31834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28b99f7
Adding try/except block to handle failed IP Addr check and comments
cclark-work Jul 17, 2025
202b60b
Making Pylint required changes to comments
cclark-work Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,15 @@ def prepare_private_dns_zone(db_context, resource_group, server_name, private_dn

def prepare_public_network(public_access, yes):
if public_access is None:
ip_address = get(IP_ADDRESS_CHECKER).text
try:
# In USSec and USNat, the IP address checker is not available as the public Internet is not accessible.
# When the user does not provide a public IP address or does not disble public access,
# the `az cli postgres flexible-server create` command will fail with the error
# HTTPSConnectionPool(host='api.ipify.org', port443): Max retries excceeded with url
ip_address = get(IP_ADDRESS_CHECKER).text
except Exception as ex:
raise CLIError("Unable to detect your current IP address. Please provide a valid IP address or CIDR range for --public-access parameter or set --public-access Disabled. Error: {}".format(ex))

logger.warning("Detected current client IP : %s", ip_address)
if yes:
return ip_address, ip_address
Expand Down
Loading