{Databoxedge} az databoxedge: Migrate to AAZ#31839
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
cxznmhdcxz
changed the title
az databoxedge: Migrate to AAZ
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the az databoxedge module from the traditional Azure CLI extension to the new AAZ (Azure AutoRest for Azure CLI) framework, representing a complete structural overhaul of the module's implementation.
- Migration from manual implementation to AAZ-generated code structure
- Replacement of custom command functions with AAZ command classes
- Introduction of new AAZ-based file organization under the
aaz/latest/databoxedgedirectory structure
Reviewed Changes
Copilot reviewed 47 out of 54 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
custom.py |
Replaces old custom implementation with AAZ-based OrderCreate class and schema modifications |
commands.py |
Updates command registration to use new AAZ command structure |
action.py |
Removes old action implementation (now empty after removing imports) |
| Manual module files | Complete removal of old manual implementation files (custom.py, commands.py, _params.py, _help.py, init.py) |
| AAZ module files | Addition of new AAZ-generated command implementations for device and order operations |
|
|
||
| @register_command( | ||
| "databoxedge order delete", | ||
| confirmation="Are you sure you want to perform this operation?", |
There was a problem hiding this comment.
The delete command should include confirmation=True parameter in the @register_command decorator for dangerous operations that remove resources.
|
|
||
| @register_command( | ||
| "databoxedge device delete", | ||
| confirmation="Are you sure you want to perform this operation?", |
There was a problem hiding this comment.
The delete command should include confirmation=True parameter in the @register_command decorator for dangerous operations that remove resources.
@cxznmhdcxz , are these breaking changes expected? |
|
@cxznmhdcxz , please remove the dependency of sdk package as well. |
cxznmhdcxz
changed the title
az databoxedge: Migrate to AAZaz databoxedge: Migrate to AAZ
Related command
az databoxedgemoduleDescription
aaz Azure/aaz#812
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.