[ServiceFabric] az sf managed-node-type update: Add parameters --vm-size and --tags#31844
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Jul 28, 2025
Merged
[ServiceFabric] az sf managed-node-type update: Add parameters --vm-size and --tags#31844zhoxing-ms merged 2 commits intoAzure:devfrom
az sf managed-node-type update: Add parameters --vm-size and --tags#31844zhoxing-ms merged 2 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| sf managed-node-type create | cmd sf managed-node-type create added parameter tags |
||
| sf managed-node-type update | cmd sf managed-node-type update added parameter tags |
||
| sf managed-node-type update | cmd sf managed-node-type update added parameter vm_size |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new parameters (--vm-size and --tags) to the az sf managed-node-type update command for Azure Service Fabric managed clusters. The changes enable users to update VM size and tags for existing node types without recreating them.
Key changes:
- Added
vm_sizeandtagsparameters to the update command implementation - Enhanced test coverage with a new test specifically for node type updates
- Updated help documentation with examples for the new parameters
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| managed_node_types.py | Added vm_size and tags parameter handling to update_node_type function |
| _params.py | Added parameter definitions for vm_size and tags in update context |
| _help.py | Added help examples demonstrating usage of new vm-size and tags parameters |
| test_sf_managed_cluster.py | Added comprehensive test for node type update functionality and updated existing tests with required tags |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
microsoft-github-policy-service
bot
added
Service Fabric
zhoxing-ms
approved these changes
Jul 28, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az sf managed-node-type updateDescription
Add parameters
--vm-sizeand--tags.Testing Guide
See tests and help.md
History Notes
[ServiceFabric]
az sf managed-node-type update: Add parameters--vm-sizeand--tagsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.