[AKS] Add command options to toggle the run command feature on or off#31854
Merged
zhoxing-ms merged 5 commits intoAzure:devfrom Jul 25, 2025
Merged
[AKS] Add command options to toggle the run command feature on or off#31854zhoxing-ms merged 5 commits intoAzure:devfrom
zhoxing-ms merged 5 commits intoAzure:devfrom
Conversation
FumingZhang
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @FumingZhang, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter disable_run_command |
||
| aks update | cmd aks update added parameter disable_run_command |
||
| aks update | cmd aks update added parameter enable_run_command |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds command options to toggle the run command feature on or off for AKS clusters. The run command feature allows executing commands on AKS cluster nodes, and this enhancement provides granular control over its enablement through CLI flags.
Key Changes
- Added
--disable-run-commandflag foraz aks createto disable the feature during cluster creation - Added
--enable-run-commandand--disable-run-commandflags foraz aks updateto toggle the feature post-creation - Implemented validation logic to prevent mutually exclusive flags from being used simultaneously
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| _params.py | Added parameter definitions for the new run command flags |
| _help.py | Added help documentation for the new command options |
| custom.py | Added new parameters to function signatures |
| managed_cluster_decorator.py | Implemented core logic for handling run command configuration |
| test_managed_cluster_decorator.py | Added comprehensive unit tests for the new functionality |
| test_aks_commands.py | Added integration tests for the run command feature |
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
modified the milestones:
September 2025 (2025-09-02),
August 2025 (2025-08-05)
mbifeld
previously approved these changes
Jul 23, 2025
Collaborator
|
Please fix conflicts |
FumingZhang
force-pushed
the
fuming/aks-run-command-0721
branch
from
e86e9f5 to
1e9b96c
Compare
mbifeld
reviewed
Jul 24, 2025
…managed_cluster_decorator.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zhoxing-ms
approved these changes
Jul 25, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks createaz aks updateDescription
Add command options to toggle the run command feature on or off
Testing Guide
History Notes
[AKS]
az aks create: Add new parameter--disable-run-commandto disable run command feature for the cluster[AKS]
az aks update: Add new parameters--disable-run-commandand--enable-run-commandto toggle the run command feature on or offThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.