[Compute] Fix issue #31685: az vm/vmss update Fix error with NoneType object has no attribute mode when update wireserver profile#31855
Merged
zhoxing-ms merged 3 commits intoAzure:devfrom Jul 22, 2025
Conversation
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #31685 where az vm update and az vmss update commands fail with "'NoneType' object has no attribute 'mode'" error when updating wireserver profile settings. The fix ensures that wireserver and imds settings objects are properly initialized before attempting to access their attributes.
- Adds proper null checks and initialization for wireserver and imds settings in proxy agent configurations
- Updates test cases to validate the fix with proper error handling expectations
- Refactors test setup to use unique resource names to avoid conflicts
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Fixes the core issue by adding null checks and conditional property setting for proxy agent settings in both VM and VMSS update functions |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Updates test cases to validate the fix and improves test isolation with unique resource names |
| wire_server=wire_server, imds=imds) | ||
| else: | ||
| if vmss.virtual_machine_profile.security_profile.proxy_agent_settings.wire_server is None: | ||
| vmss.virtual_machine_profile.security_profile.wire_server = wire_server |
There was a problem hiding this comment.
This line incorrectly assigns wire_server to security_profile.wire_server instead of security_profile.proxy_agent_settings.wire_server. It should be vmss.virtual_machine_profile.security_profile.proxy_agent_settings.wire_server = wire_server.
Suggested change
| vmss.virtual_machine_profile.security_profile.wire_server = wire_server | |
| vmss.virtual_machine_profile.security_profile.proxy_agent_settings.wire_server = wire_server |
Jing-song
changed the title
az vm/vmss update Fix error with 'NoneType' object has no attribute 'mode' when update wireserver profileaz vm/vmss update Fix error with NoneType object has no attribute mode when update wireserver profile
microsoft-github-policy-service
bot
added
the
Compute
zhoxing-ms
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm/vmss updateDescription
close #31685
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.