[Compute] az compute-recommender spot-placement-score: Add new command to replace original command az compute-recommender spot-placement-recommender#31858
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @Elina-L, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| compute-recommender spot-placement-recommender | cmd compute-recommender spot-placement-recommender added property deprecate_info_hide |
||
| compute-recommender spot-placement-recommender | cmd compute-recommender spot-placement-recommender added property deprecate_info_redirect |
||
| compute-recommender spot-placement-recommender | cmd compute-recommender spot-placement-recommender added property deprecate_info_target |
||
| compute-recommender spot-placement-score | cmd compute-recommender spot-placement-score added |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure CLI compute-recommender module to change the command from az compute-recommender spot-placement-recommender to az compute-recommender spot-placement-score and updates the API version to stable 2025-06-05.
- Adds a new
SpotPlacementScorecommand class to replace the existing spot placement recommender functionality - Updates the command name to better reflect its purpose of generating placement scores
- Upgrades to use the stable 2025-06-05 API version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
_spot_placement_score.py |
New command implementation for spot placement score generation with updated API version |
__init__.py |
Import statement to expose the new SpotPlacementScore command |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Elina-L
changed the title
Elina-L
changed the title
Elina-L
changed the title
az compute-recommender spot-placement-score Add Spot Placement Score 2025-06-05 Stable version command
Elina-L
changed the title
az compute-recommender spot-placement-score Add Spot Placement Score 2025-06-05 Stable version commandaz compute-recommender spot-placement-score: Add Spot Placement Score 2025-06-05 Stable version command
|
Commenter does not have sufficient privileges for PR 31858 in repo Azure/azure-cli |
Elina-L
requested review from
FumingZhang,
bebound,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms and
wangzelin007
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Elina-L
force-pushed
the
wenxliu/RecommenderRPSpotPlacementScore20250605
branch
from
8dc4cf0 to
efcd3f8
Compare
May I ask why you are not considering upgrading the api-version of the original command and instead creating a new command? |
Hi Xing, the API used to be spotplacementrecommender, but our team renamed the API to spotplacementscore. I've added the new "score" command to align with the API's name and also the API path. We plan to deprecate the "recommender" version of the command in the future, but our number one priority right now is to merge this PR in time for August release. However, if retaining the same "spot placement recommender" name and upgrading the API version of "spot placement recommender" would help speed up the PR review, I can do that for this PR, then deprecate the command and replace it with "spot-placement-score" in a future PR instead. |
|
Thank you for your detailed explanation. I think you can upgrade the api-version only for |
Hi Xing, I'm trying to understand how to implement the command you shared: deprecate_info=self.deprecate(redirect='az compute-recommender spot-placement-score', hide=True) Is there any wiki or example I can reference? I'm checking in the code and it is referenced within "load_command_table" methods, in the commands.py, should I do something similar? 
|
…ment-recommender with spot-placement-score Adding deprecate_info=self.deprecate(redirect to deprecate spot-placement-recommender with spot-placement-score, and passing Adding deprecate_info=self.deprecate(redirect to deprecate spot-placement-recommender with spot-placement-score, and passing
Elina-L
force-pushed
the
wenxliu/RecommenderRPSpotPlacementScore20250605
branch
from
38ceb02 to
074489c
Compare
Updated the code in compute-recommender/commands.py: 
|
zhoxing-ms
changed the title
az compute-recommender spot-placement-score: Add Spot Placement Score 2025-06-05 Stable version commandaz compute-recommender spot-placement-score: Add new command to replace original command az compute-recommender spot-placement-recommender
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi Xing, after reviewing the code, again, is this section correct? 
On the third line in this image, should it be 'az compute-recommender spot-placement-recommender' instead? |
…ot-placement-score, change command_group to compute-recommender spot-placement-recommender
|
I was able to fix the deprecation issue by adding _breaking_change.py file according to this wiki: azure-cli/doc/how_to_introduce_breaking_changes.md at dev · Azure/azure-cli It's working after validation: Running the command via the old name is still successful: Running new command is also successful |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az compute-recommender spot-placement-score
Description
Changing the command from az compute-recommender spot-placement-recommender to az compute-recommender spot-placement-score.
Update version to stable 2025-06-05
Azure/aaz#816
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.