[AKS] az aks update: Support updating load balancer sku from basic to standard#31874
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom Jul 28, 2025
Merged
[AKS] az aks update: Support updating load balancer sku from basic to standard#31874zhoxing-ms merged 1 commit intoAzure:devfrom
az aks update: Support updating load balancer sku from basic to standard#31874zhoxing-ms merged 1 commit intoAzure:devfrom
Conversation
nilo19
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nilo19, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter load_balancer_sku |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for updating the load balancer SKU from basic to standard in AKS clusters through the az aks update command. The implementation modifies the load balancer SKU handling logic to support update scenarios and adds the --load-balancer-sku standard parameter to the update command.
Key changes include:
- Modified load balancer SKU getter to handle UPDATE mode properly by reading from existing cluster when parameter is None
- Added load balancer SKU update logic to the network profile update method
- Extended the update command to accept the load balancer SKU parameter with validation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| managed_cluster_decorator.py | Updated _get_load_balancer_sku method to support UPDATE mode and added SKU update logic in update_network_profile |
| custom.py | Added load_balancer_sku parameter to the aks_update function signature |
| _params.py | Added load balancer SKU argument configuration for the update command with validation |
| _help.py | Added help documentation for the new --load-balancer-sku parameter and usage example |
| test_managed_cluster_decorator.py | Added comprehensive test coverage for the new functionality including UPDATE mode scenarios |
| long-summary: Define the LoadBalancer backend pool type of managed inbound backend pool. The nodeIP means the VMs will be attached to the LoadBalancer by adding its private IP address to the backend pool. The nodeIPConfiguration means the VMs will be attached to the LoadBalancer by referencing the backend pool ID in the VM's NIC. | ||
| - name: --load-balancer-sku | ||
| type: string | ||
| short-summary: Azure Load Balancer SKU selection for your cluster. only standard is accepted. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Consider changing 'Azure Load Balancer SKU selection for your cluster. only standard is accepted.' to 'Select Azure Load Balancer SKU for your cluster. Only standard is accepted.'
| - name: --load-balancer-sku | ||
| type: string | ||
| short-summary: Azure Load Balancer SKU selection for your cluster. only standard is accepted. | ||
| long-summary: Upgrade to Standard Azure Load Balancer SKU for your AKS cluster. |
There was a problem hiding this comment.
The help message should start with an active voice verb in first person. Consider changing 'Upgrade to Standard Azure Load Balancer SKU for your AKS cluster.' to 'Upgrade your AKS cluster to Standard Azure Load Balancer SKU.'
| long-summary: Define the LoadBalancer backend pool type of managed inbound backend pool. The nodeIP means the VMs will be attached to the LoadBalancer by adding its private IP address to the backend pool. The nodeIPConfiguration means the VMs will be attached to the LoadBalancer by referencing the backend pool ID in the VM's NIC. | ||
| - name: --load-balancer-sku | ||
| type: string | ||
| short-summary: Azure Load Balancer SKU selection for your cluster. only standard is accepted. |
There was a problem hiding this comment.
The word 'only' should be capitalized at the beginning of the sentence: 'Only standard is accepted.'
Suggested change
| short-summary: Azure Load Balancer SKU selection for your cluster. only standard is accepted. | |
| short-summary: Azure Load Balancer SKU selection for your cluster. Only standard is accepted. |
nilo19
force-pushed
the
feat/blb-migration
branch
from
20f57de to
9b46c93
Compare
microsoft-github-policy-service
bot
added
Auto-Assign
Member
Author
|
related: Azure/azure-cli-extensions#8731 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nilo19
changed the title
FumingZhang
changed the title
az aks update: Support updating load balancer sku from basic to standard
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
Jul 28, 2025
zhoxing-ms
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks update --load-balancer-sku standard
Description
feat: Support updating load balancer sku from basic to standard
Testing Guide
az aks update --load-balancer-sku standard # migrate from basic lb to standard
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.