{AKS} Bump SDK to adopt singleapi #31877
Merged
zhoxing-ms merged 6 commits intoAzure:devfrom Aug 5, 2025
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @FumingZhang, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
requested review from
bebound,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms and
necusjz
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Kubernetes Service (AKS) CLI module to adopt a single API approach by bumping the azure-mgmt-containerservice SDK from version 38.0.0 to 39.0.0. This change eliminates the need for versioned API profiles and simplifies the SDK usage.
- Updates SDK dependency from
azure-mgmt-containerservice~=38.0.0toazure-mgmt-containerservice~=39.0.0 - Removes API version constraints and simplifies model imports to use direct paths
- Cleans up deprecated completers and removes minimum API version requirements
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updates SDK dependency version in setup configuration |
| src/azure-cli/requirements.py3.*.txt | Updates SDK version in platform-specific requirements files |
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_*.py | Simplifies model imports by removing versioned API logic |
| src/azure-cli/azure/cli/command_modules/acs/commands.py | Removes minimum API version constraints from commands |
| src/azure-cli/azure/cli/command_modules/acs/_params.py | Removes VM size completer and its import |
| src/azure-cli/azure/cli/command_modules/acs/_completers.py | Removes VM size completion function |
| src/azure-cli-core/azure/cli/core/profiles/_shared.py | Sets container service resource type profile to None |
| @@ -118,9 +118,9 @@ def load_command_table(self, _): | |||
| confirmation='Kubernetes will be unavailable during certificate rotation process.\n' + | |||
| 'Are you sure you want to perform this operation?') | |||
| g.custom_command('stop', 'aks_stop', | |||
There was a problem hiding this comment.
The 'stop' command performs a potentially dangerous operation that will make Kubernetes unavailable. Consider adding confirmation=True parameter to ensure users confirm this action.
zhoxing-ms
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
{AKS} Bump SDK to adopt singleapi
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.