Conversation
️✔️AzureCLI-FullTest
|
|
Hi @Shi1810, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the az webapp deploy command to support warming up Kudu using both SCM endpoints and ARM deployment APIs. The change enables more flexible Kudu warm-up strategies based on the deployment type being used.
- Adds new functions to build Kudu warm-up URLs for both SCM and ARM endpoints
- Refactors the warm-up logic to select the appropriate endpoint based on deployment parameters
- Updates function signatures to accept a params object instead of individual parameters
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/appservice/custom.py:7722
- The return value is inconsistent with other return statements in this function. Line 7922 returns
Nonewhile line 7722 still returnsFalse. This should be changed toreturn Nonefor consistency.
base_url = (
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @Shi1810! We will review the pull request and get back to you soon. |
sarsharma
reviewed
Jul 28, 2025
sarsharma
reviewed
Jul 28, 2025
sarsharma
reviewed
Jul 28, 2025
added 5 commits
July 29, 2025 15:51
…shikhajha/arm_warmup
…shikhajha/arm_warmup
Shi1810
requested review from
bebound,
calvinhzy,
kairu-ms and
necusjz
as code owners
sarsharma
approved these changes
Aug 14, 2025
kumaramit-msft
approved these changes
Aug 14, 2025
yanzhudd
changed the title
az webapp deploy : Warm-up kudu using ARM warm-up API before making ARM deploymentaz webapp deploy: Warm-up kudu using ARM warm-up API before making ARM deployment
Collaborator
|
Please fix CI issues |
yanzhudd
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp deployDescription
Currently, we are only warming-up Kudu using SCM endpoint:
api/deployments?warmup=true. We want to warm-up using ARM deployments API for ARM deployments. Therefore, now we are building separate Warm-up API for SCM and ARM deployments.Screenshot
Testing Guide
Deploying app using az webapp deploy with source url should work as expected.
History Notes
[App Service]
az webapp deploy: Add--enable-kudu-warmupparameter to support warm-up Kudu before making deploymentThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.