[ContainerApp] Fix #31762: az containerapp job list: Fix bug only 20 items are returned#31888
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Jul 30, 2025
Merged
[ContainerApp] Fix #31762: az containerapp job list: Fix bug only 20 items are returned#31888zhoxing-ms merged 2 commits intoAzure:devfrom
az containerapp job list: Fix bug only 20 items are returned#31888zhoxing-ms merged 2 commits intoAzure:devfrom
Conversation
Juliehzl
requested review from
Greedygre,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Copilot,
jsntcy,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a pagination bug in the az containerapp job list command where only the first 20 items were being returned instead of all available container app jobs. The fix implements proper handling of paginated API responses by following nextLink tokens to retrieve all pages of results.
- Adds pagination handling to both subscription-level and resource group-level job listing methods
- Includes a comprehensive test that creates 30 jobs to verify the pagination fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
_clients.py |
Implements pagination logic in list_by_subscription and list_by_resource_group methods to handle nextLink responses |
test_containerappjob_crud.py |
Adds test case that creates 30 jobs and verifies all are returned by the list command |
|
|
||
| # get list of Container App Jobs | ||
| jobs_list = self.cmd("az containerapp job list --resource-group {}".format(resource_group)).get_output_in_json() | ||
| self.assertTrue(len(jobs_list) == 30) |
There was a problem hiding this comment.
Use self.assertEqual(len(jobs_list), 30) instead of self.assertTrue for better error messages when the assertion fails. This will show the actual vs expected count in test failures.
Suggested change
| self.assertTrue(len(jobs_list) == 30) | |
| self.assertEqual(len(jobs_list), 30) |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
pagariyaalok,
sanchitmehta,
torosent,
vinisoto and
vturecek
chinadragon0515
approved these changes
Jul 30, 2025
zhoxing-ms
approved these changes
Jul 30, 2025
zhoxing-ms
changed the title
az containerapp job list: Fix bug only 20 items are returnedaz containerapp job list: Fix bug only 20 items are returned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp job listDescription
Fix #31762
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.