Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| snapshot create | cmd snapshot create added parameter instant_access_duration_minutes |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
the
Compute
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for creating instant access snapshots for Premium SSD v2 and Ultra Disk by introducing a new --enable-instant-access parameter to the az snapshot create command.
- Adds a new test case to verify the
--enable-instant-accessfunctionality - Updates test recordings to reflect the new parameter usage
- Adds test skips for failing tests unrelated to the main feature
Reviewed Changes
Copilot reviewed 15 out of 30 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Adds new test for instant access snapshot functionality and skips failing tests |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_snapshot_incremental.yaml | Updates recorded HTTP interactions with API version changes and new response fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+1637
to
+1644
| self.kwargs.update({ | ||
| 'disk': self.create_random_name('disk', 15), | ||
| 'snapshot': self.create_random_name('snapshot', 15) | ||
| }) | ||
| self.cmd('disk create -g {rg} -n {disk} --size-gb 10 --sku UltraSSD_LRS') | ||
| self.cmd('snapshot create -g {rg} -n {snapshot} --enable-instant-access 300 --incremental true --source {disk}', checks=[ | ||
| self.check('incremental', True), | ||
| self.check('creationData.instantAccessDurationMinutes', 300) |
There was a problem hiding this comment.
[nitpick] The command uses a hard-coded value of 300 for the instant access duration. Consider using a variable or constant to make the test more maintainable and self-documenting about what this value represents (e.g., duration in minutes).
Suggested change
| self.kwargs.update({ | |
| 'disk': self.create_random_name('disk', 15), | |
| 'snapshot': self.create_random_name('snapshot', 15) | |
| }) | |
| self.cmd('disk create -g {rg} -n {disk} --size-gb 10 --sku UltraSSD_LRS') | |
| self.cmd('snapshot create -g {rg} -n {snapshot} --enable-instant-access 300 --incremental true --source {disk}', checks=[ | |
| self.check('incremental', True), | |
| self.check('creationData.instantAccessDurationMinutes', 300) | |
| instant_access_duration_minutes = 300 | |
| self.kwargs.update({ | |
| 'disk': self.create_random_name('disk', 15), | |
| 'snapshot': self.create_random_name('snapshot', 15) | |
| }) | |
| self.cmd('disk create -g {rg} -n {disk} --size-gb 10 --sku UltraSSD_LRS') | |
| self.cmd(f'snapshot create -g {{rg}} -n {{snapshot}} --enable-instant-access {instant_access_duration_minutes} --incremental true --source {{disk}}', checks=[ | |
| self.check('incremental', True), | |
| self.check('creationData.instantAccessDurationMinutes', instant_access_duration_minutes) |
yanzhudd
reviewed
Aug 25, 2025
Jing-song
changed the title
az snapshot create: Add new parameter --enable-instant-access to support creating instant access snapshot for premium SSD v2 and ultra diskaz snapshot create: Add new parameter --instant-access-duration-minutes to support creating instant access snapshot for premium SSD v2 and ultra disk
Contributor
|
License check: @microsoft-github-policy-service rerun |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az snapshot createDescription
Instant Access Snapshot for Premium SSD v2 and Ultra Disk
close: #31717
AAZ: Azure/aaz#836
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.