Skip to content

[Container App] az containerapp job update: Fix --min-executions and --max-executions not accepting 0 values #31906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 2 commits into from
Aug 7, 2025
Merged

[Container App] az containerapp job update: Fix --min-executions and --max-executions not accepting 0 values #31906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77931a0
Fixing issue: Min/Max-Executions not set in az containerapp job update
khushishah513 Aug 2, 2025
55c6c4d
testing without containerapp extension
khushishah513 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,7 +1174,7 @@ def update_containerappsjob_logic(cmd,

update_map = {}
update_map['replicaConfigurations'] = replica_timeout or replica_retry_limit
update_map['triggerConfigurations'] = replica_completion_count or parallelism or cron_expression or scale_rule_name or scale_rule_type or scale_rule_auth or polling_interval or min_executions or max_executions
update_map['triggerConfigurations'] = replica_completion_count or parallelism or cron_expression or scale_rule_name or scale_rule_type or scale_rule_auth or polling_interval or min_executions is not None or max_executions is not None
Copy link

Copilot AI Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is extremely long and hard to read. Consider breaking it into multiple lines for better readability, using parentheses for proper alignment.

Suggested change
update_map['triggerConfigurations'] = replica_completion_count or parallelism or cron_expression or scale_rule_name or scale_rule_type or scale_rule_auth or polling_interval or min_executions is not None or max_executions is not None
update_map['triggerConfigurations'] = (
replica_completion_count
or parallelism
or cron_expression
or scale_rule_name
or scale_rule_type
or scale_rule_auth
or polling_interval
or min_executions is not None
or max_executions is not None
)

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushishah513 @Greedygre I think Copilot's suggestion is worth considering, what do you think?

update_map['container'] = image or container_name or set_env_vars is not None or remove_env_vars is not None or replace_env_vars is not None or remove_all_env_vars or cpu or memory or startup_command is not None or args is not None
update_map['registry'] = registry_server or registry_user or registry_pass

Expand Down
Loading
Loading