{Compute} az vmss start: Migrate to CodeGen based#31909
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vmss start | cmd vmss start update parameter instance_ids: added property aaz_type=AAZListArg |
||
| vmss start | cmd vmss start update parameter instance_ids: added property type=List<String> |
||
| vmss start | cmd vmss start update parameter no_wait: added property aaz_type=bool |
||
| vmss start | cmd vmss start update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| vmss start | cmd vmss start update parameter no_wait: added property nargs=? |
||
| vmss start | cmd vmss start update parameter no_wait: added property type=bool |
||
| vmss start | cmd vmss start update parameter resource_group_name: added property aaz_type=string |
||
| vmss start | cmd vmss start update parameter resource_group_name: added property type=string |
||
| vmss start | cmd vmss start update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| vmss start | cmd vmss start update parameter vm_scale_set_name: added property aaz_type=string |
||
| vmss start | cmd vmss start update parameter vm_scale_set_name: added property id_part=name |
||
| vmss start | cmd vmss start update parameter vm_scale_set_name: added property type=string |
||
| vmss start | cmd vmss start update parameter vm_scale_set_name: updated property name from vm_scale_set_name to name |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31909 in repo Azure/azure-cli |
Contributor
Author
|
/azp list |
Collaborator
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31909 in repo Azure/azure-cli |
|
Azure Pipelines successfully started running 3 pipeline(s). |
naga-nandyala
changed the title
naga-nandyala
force-pushed
the
naga/vmss_start
branch
from
3170d4b to
708e6f7
Compare
naga-nandyala
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the az vmss start command from custom implementation to CodeGen based implementation. The change replaces the manually written command with an auto-generated AAZ (Azure CLI Auto-Generated) command structure.
- Removes the custom
start_vmssfunction and replaces it with a CodeGen-basedVMSSStartclass - Adds auto-generated command implementation in the AAZ module
- Updates imports and command registration to use the new implementation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/operations/vmss.py | Adds new VMSSStart class that extends the auto-generated Start class with custom logic for handling instance IDs |
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Removes the old start_vmss function implementation |
| src/azure-cli/azure/cli/command_modules/vm/commands.py | Removes the custom command registration for vmss start |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/_start.py | New auto-generated command implementation file |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/init.py | Adds import for the new start command |
| src/azure-cli/azure/cli/command_modules/vm/_params.py | Removes vmss start from the parameter scope list |
| src/azure-cli/azure/cli/command_modules/vm/_help.py | Removes the manual help documentation for vmss start command |
yanzhudd
reviewed
Aug 18, 2025
yanzhudd
reviewed
Aug 18, 2025
yanzhudd
changed the title
az vmss start: Migrate to CodeGen based
naga-nandyala
requested review from
bebound,
calvinhzy,
evelyn-ys,
jiasli,
kairu-ms and
necusjz
as code owners
naga-nandyala
force-pushed
the
naga/vmss_start
branch
from
aec792a to
7a39a3f
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Aug 21, 2025
Contributor
|
please make sure to push the latest changes to aaz repo. |
Contributor
Author
Yes this has been done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmss startDescription
aaz PR: Azure/aaz#824
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.