Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Service Fabric
There was a problem hiding this comment.
Pull Request Overview
This PR adds breaking change pre-announcement warnings for argument deprecation in Service Fabric commands, specifically for az sf application update and az sf managed-application update commands. The changes are targeted for November 2025 and will warn users about upcoming argument removals.
- Registers deprecation warnings for multiple health policy and timeout arguments
- Covers both standard and managed Service Fabric application update commands
- Uses the
hide=Trueflag to suppress the arguments from help while maintaining backward compatibility
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
modified the milestones:
September 2025 (2025-09-02),
October 2025 (2025-10-14)
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
|
@yanzhudd Hi, I resolved the comment. Would it be possible to keep this in the September milestone? I thought the docs said I needed the annoucements two releases before the breaking changes were merged. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like the integration tests are failing, but I'm not familiar with the error code being thrown. Is there suggestion or action I can take on my part to fix this? |
|
Please move the breaking change announcements to the module folder corresponding to the relevant commands (like https://github.com/Azure/azure-cli/tree/41969a2c7055f805362909caf42409eb8b180255/src/azure-cli/azure/cli/command_modules/servicefabric) |
|
please make the changes ASAP, as the code completion time for the upcoming release is approaching (08/26/2025 07:00 UTC) |
Thanks! Made the change. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az sf application updateaz sf managed-application updateaz sf managed-application-type version updateDescription
Adding pre-announcement for breaking changes in #31814 targeting Nov 2025, which which fixes #28574 and fixes #31750.
Adding pre-announcement for breaking change to mark
--package-urlparameter foraz sf managed-application-type version updateas required due to changes in service due to security pushes that do not allow us to return the customer url as a non-secure string.Testing Guide
N/A
History Notes
[Service Fabric]
az sf managed-application update: Add breaking change pre-announcement warnings for argument option removal[Service Fabric]
az sf managed-application-type version update: Add breaking change pre-announcement warnings for required argument--package-urlThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.