[Compute] az disk create/grant-access: Support Confidential VM OS Disks#31934
Merged
[Compute] az disk create/grant-access: Support Confidential VM OS Disks#31934
az disk create/grant-access: Support Confidential VM OS Disks#31934Conversation
yanzhudd
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| disk create | cmd disk create added parameter security_metadata_uri |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Confidential VM OS disks in the az disk create and az disk grant-access commands. The changes enable handling of security metadata URIs for Confidential VM configurations and update the API version to support new security options.
Key changes include:
- Added
security_metadata_uriparameter toaz disk createcommand for Confidential VM metadata - Updated API version from 2023-04-02 to 2025-01-02 for enhanced Confidential VM support
- Added new security type
ConfidentialVM_NonPersistedTPMand security option support
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/custom.py |
Added security_metadata_uri parameter to disk creation function |
src/azure-cli/azure/cli/command_modules/vm/_params.py |
Added CLI argument definition for security_metadata_uri |
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/disk/_create.py |
Updated API version and added support for new Confidential VM features including security metadata URI |
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/disk/_grant_access.py |
Updated API version and added security metadata access SAS support |
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py |
Updated tests to include new --secure-vm-guest-state-sas parameter |
| c.argument('upload_type', arg_type=get_enum_type(['Upload', 'UploadWithSecurityData']), min_api='2018-09-30', | ||
| help="Create the disk for upload scenario. 'Upload' is for Standard disk only upload. 'UploadWithSecurityData' is for OS Disk upload along with VM Guest State. Please note the 'UploadWithSecurityData' is not valid for data disk upload, it only to be used for OS Disk upload at present.") | ||
| c.argument('performance_plus', arg_type=get_three_state_flag(), min_api='2022-07-02', help='Set this flag to true to get a boost on the performance target of the disk deployed. This flag can only be set on disk creation time and cannot be disabled after enabled') | ||
| c.argument('security_metadata_uri', help='Specify the blob URI to be imported into VM metadata for Confidential VM') |
There was a problem hiding this comment.
The help message should start with an active voice verb in first person. Consider changing 'Specify the blob URI...' to 'Import the blob URI...' or 'Set the blob URI...' to follow the help message format guidelines.
microsoft-github-policy-service
bot
added
the
Compute
…-confidential-vm-v2
…udd/azure-cli into support-confidential-vm-v2
zhoxing-ms
approved these changes
Aug 22, 2025
…-confidential-vm-v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az disk create/grant-accessDescription
Close: #31881
aaz PR: Azure/aaz#837
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.