{Compute} vmss delete-instances: migrate to codegen based command#31962
Merged
{Compute} vmss delete-instances: migrate to codegen based command#31962
vmss delete-instances: migrate to codegen based command#31962Conversation
️✔️AzureCLI-FullTest
|
|
Hi @DanielMicrosoft, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vmss delete-instances | cmd vmss delete-instances update parameter instance_ids: added property aaz_type=AAZListArg |
||
| vmss delete-instances | cmd vmss delete-instances update parameter instance_ids: added property type=List<String> |
||
| vmss delete-instances | cmd vmss delete-instances update parameter no_wait: added property aaz_type=bool |
||
| vmss delete-instances | cmd vmss delete-instances update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| vmss delete-instances | cmd vmss delete-instances update parameter no_wait: added property nargs=? |
||
| vmss delete-instances | cmd vmss delete-instances update parameter no_wait: added property type=bool |
||
| vmss delete-instances | cmd vmss delete-instances update parameter resource_group_name: added property aaz_type=string |
||
| vmss delete-instances | cmd vmss delete-instances update parameter resource_group_name: added property type=string |
||
| vmss delete-instances | cmd vmss delete-instances update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| vmss delete-instances | cmd vmss delete-instances update parameter vm_scale_set_name: added property aaz_type=string |
||
| vmss delete-instances | cmd vmss delete-instances update parameter vm_scale_set_name: added property id_part=name |
||
| vmss delete-instances | cmd vmss delete-instances update parameter vm_scale_set_name: added property type=string |
||
| vmss delete-instances | cmd vmss delete-instances update parameter vm_scale_set_name: updated property name from vm_scale_set_name to name |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
DanielMicrosoft
changed the title
DanielMicrosoft
changed the title
DanielMicrosoft
changed the title
vmss delete_instances: migrate to codegen based command
DanielMicrosoft
changed the title
vmss delete_instances: migrate to codegen based commandvmss delete-instances: migrate to codegen based command
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
reviewed
Aug 22, 2025
yanzhudd
reviewed
Aug 22, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
DanielMicrosoft
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the az vmss delete-instances command from a custom implementation to a codegen-based command using the AAZ framework.
- Removes the custom function
delete_vmss_instancesand its registration from the VM module - Introduces a new auto-generated command class
DeleteInstancesin the AAZ framework - Updates parameter handling and help documentation to align with the new implementation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
custom.py |
Removes the custom delete_vmss_instances function implementation |
commands.py |
Removes the registration of the custom delete-instances command |
_delete_instances.py |
Adds new auto-generated AAZ command class for delete-instances functionality |
__init__.py |
Imports the new _delete_instances module |
_params.py |
Removes parameter configuration for the old custom command |
_help.py |
Removes the old help documentation (now handled by the AAZ command) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yanzhudd
approved these changes
Aug 24, 2025
necusjz
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmss delete-instancesDescription
aaz PR: Azure/aaz#830
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.