Skip to content

[ARM] Fix #31581: az deployment group create: Fix error message being hidden when template validation fails #31965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 1 commit into from
Sep 10, 2025
Merged

[ARM] Fix #31581: az deployment group create: Fix error message being hidden when template validation fails #31965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/azure-cli/azure/cli/command_modules/resource/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,7 @@ def _build_preflight_error_message(preflight_error):


def _build_http_response_error_message(http_error):
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function now directly calls http_error.response.json()['error'] without any error handling. Consider adding appropriate exception handling for cases where the response might not contain valid JSON or the expected 'error' key structure.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@micromaomao micromaomao Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is existing behaviour.

from azure.core.exceptions import StreamClosedError, StreamConsumedError
try:
error_txt = http_error.response.internal_response.text
error_info = json.loads(error_txt)['error']
except (StreamClosedError, StreamConsumedError):
error_info = http_error.response.json()['error']
error_info = http_error.response.json()['error']
error_details = error_info.pop('details') if 'details' in error_info else []
err_messages = [f'{json.dumps(error_info)}']

Expand Down