[Servicebus] az Servicebus namespace: Add nsp-configuration show and nsp-configuration list#31970
Draft
schaudhari6254888 wants to merge 1 commit intoAzure:devfrom
Draft
[Servicebus] az Servicebus namespace: Add nsp-configuration show and nsp-configuration list#31970schaudhari6254888 wants to merge 1 commit intoAzure:devfrom
az Servicebus namespace: Add nsp-configuration show and nsp-configuration list#31970schaudhari6254888 wants to merge 1 commit intoAzure:devfrom
Conversation
schaudhari6254888
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @schaudhari6254888, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| servicebus namespace nsp-configuration | sub group servicebus namespace nsp-configuration added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Network Security Perimeter (NSP) configuration management commands to the Azure CLI Service Bus module. The new commands allow users to list and show NSP configurations for Service Bus namespaces, enhancing security configuration capabilities.
- Adds
nsp-configuration listandnsp-configuration showcommands for Service Bus namespaces - Updates command group descriptions for better clarity and consistency
- Reorganizes imports in the namespace module
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
__cmd_group.py (servicebus) |
Updates command group description to "Manage Service Bus" |
__cmd_group.py (namespace) |
Updates command group description to "Manage Namespace" |
__cmd_group.py (private_endpoint_connection) |
Updates description to include full command path |
__cmd_group.py (private_link_resource) |
Simplifies description to "private-link-resource" |
nsp_configuration/ |
New directory containing NSP configuration commands implementation |
namespace/__init__.py |
Reorganizes import order for consistency |
latest/__init__.py |
Adds standard pylint and flake8 skip directives |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ) | ||
| class Show(AAZCommand): | ||
| """Get a NetworkSecurityPerimeterConfigurations resourceAssociationName | ||
| """ |
There was a problem hiding this comment.
The docstring should be more descriptive and follow standard conventions. It should describe what the command does rather than just the technical parameter name.
Suggested change
| """ | |
| """ | |
| Retrieves details about a specific Network Security Perimeter Configuration resource association | |
| within a Service Bus namespace. Use this command to view configuration and association information | |
| for enhanced network security management. | |
| """ |
| ) | ||
| class List(AAZCommand): | ||
| """list of current NetworkSecurityPerimeterConfiguration for Namespace | ||
| """ |
There was a problem hiding this comment.
The docstring should start with a capital letter and be more descriptive. Consider something like "List NetworkSecurityPerimeterConfigurations for a Service Bus namespace."
Suggested change
| """ | |
| """List NetworkSecurityPerimeterConfigurations for a Service Bus namespace.""" |
microsoft-github-policy-service
bot
added
Auto-Assign
schaudhari6254888
changed the title
az Servicebus namespace: Add nsp-configuration show and nsp-configuration list
evelyn-ys
modified the milestones:
October 2025 (2025-10-14),
November 2025 (2025-11-04)
evelyn-ys
modified the milestones:
November 2025 (2025-11-04),
November 2025 (2025-11-18)❗ Breaking change release ❗
Member
|
@schaudhari6254888 Do you still want this PR? It's in draft state for several months... |
evelyn-ys
modified the milestones:
November 2025 (2025-11-18)❗ Breaking change release ❗,
Backlog
Member
Author
Hey @evelyn-ys, yes, we want this PR. we are working on one bug on service side once it's released, I'll open the PR for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
az servicebus namespace nsp-configuration listaz servicebus namespace nsp-configuration showNew cmdlets added.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.