[AKS] az command aks: Add KataVmIsolation option for --workload-runtime parameter#32020
[AKS] az command aks: Add KataVmIsolation option for --workload-runtime parameter#32020
az command aks: Add KataVmIsolation option for --workload-runtime parameter#32020Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
az command aks: Add KataVmIsolation workload runtime
587e395 to
113eb47
Compare
113eb47 to
8ee2e7c
Compare
| @AKSCustomResourceGroupPreparer( | ||
| random_name_length=17, name_prefix="clitest", location="westus2" | ||
| ) | ||
| def test_aks_cluster_kata( |
FumingZhang
left a comment
There was a problem hiding this comment.
please fix failed CI checks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Kata VM Isolation workload runtime to AKS clusters and node pools. The changes enable users to specify --workload-runtime KataVmIsolation when creating clusters or adding node pools with Kata-enabled workloads.
- Introduces
CONST_WORKLOAD_RUNTIME_KATA_VM_ISOLATIONconstant andworkload_runtimeparameter - Adds
get_workload_runtime()method toAKSAgentPoolContextfor retrieving workload runtime configuration - Includes integration tests validating Kata VM Isolation functionality for both cluster creation and nodepool addition
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
_consts.py |
Defines the constant CONST_WORKLOAD_RUNTIME_KATA_VM_ISOLATION for Kata VM Isolation |
_params.py |
Adds workload_runtime parameter to aks create and aks nodepool add commands |
_help.py |
Documents the --workload-runtime parameter and adds usage examples |
custom.py |
Adds enable_kata_workload_runtime parameter to aks_create and aks_agentpool_add functions |
agentpool_decorator.py |
Implements get_workload_runtime() method in AKSAgentPoolContext |
test_agentpool_decorator.py |
Adds unit tests for get_workload_runtime() functionality |
test_aks_commands.py |
Adds integration tests for cluster and nodepool creation with Kata VM Isolation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32020 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
az command aks: Add KataVmIsolation workload runtimeaz command aks: Add KataVmIsolation option for --workload-runtime parameter
Related command
az aks
az aks create --name myAKSCluster --resource-group myResourceGroup --os-sku AzureLinux --workload-runtime KataVmIsolation --node-vm-size Standard_D4s_v3 --node-count 1 --generate-ssh-keys
az aks nodepool add --cluster-name myAKSCluster --resource-group myResourceGroup --name nodepool2 --os-sku AzureLinux --workload-runtime KataVmIsolation --node-vm-size Standard_D4s_v3
Description
This PR adds the
KataVmIsolationworkload runtime which is being GAed.Testing Guide
python3 src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_agentpool_decorator.pyfor unit tests.pytest -k katafor test_aks_commands.py tests.Modified test is passing.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.