{Batch} Breaking Change Deprecation Warnings#32070
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom Sep 17, 2025
Merged
Conversation
cRui861
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| batch pool list | cmd batch pool list added property deprecate_info_target |
||
| batch pool show | cmd batch pool show added property deprecate_info_target |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds breaking change deprecation warnings for Azure Batch pool commands to alert users about upcoming argument and output changes. The changes include deprecating specific arguments and output fields across batch pool operations.
- Deprecates
--target-communicationand--resource-tagsarguments in pool create/reset/set commands - Adds output deprecation warnings for specific fields in pool show/list commands
- Modifies argument configuration to support deprecation handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
_breaking_change.py |
New file containing deprecation registrations for arguments and output fields |
_params.py |
Updates resource_tags argument configuration with action=None parameter |
test_batch_transformers.py |
Minor whitespace formatting change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dpwatrous
suggested changes
Sep 8, 2025
wiboris
approved these changes
Sep 9, 2025
Collaborator
|
Please fix CI issues |
dpwatrous
approved these changes
Sep 10, 2025
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
Changes look good once the whitespace issues are fixed.
zhoxing-ms
previously approved these changes
Sep 11, 2025
Contributor
|
@ReaNAiveD Could you please help review this PR as well? |
Member
|
/azp run Azure.azure-cli |
|
Commenter does not have sufficient privileges for PR 32070 in repo Azure/azure-cli |
Member
Author
|
/azp run Azure.azure-cli |
|
Commenter does not have sufficient privileges for PR 32070 in repo Azure/azure-cli |
Member
Author
|
@zhoxing-ms Some of the checks have never finished running, do you know how we can re-run them? I don't seem to have permissions to do so |
cRui861
force-pushed
the
rechen/dep-warnings
branch
from
f099204 to
f7370cc
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 tasks
cRui861
force-pushed
the
rechen/dep-warnings
branch
from
f7370cc to
cc185f6
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ReaNAiveD
approved these changes
Sep 16, 2025
zhoxing-ms
approved these changes
Sep 17, 2025
zhoxing-ms
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add breaking change descriptions for arguments
--target-communicationand--resource-tagsin commandsaz batch pool create,az batch pool reset, andaz batch pool set. Also set output deprecation warnings fortargetNodeCommunicationMode,currentNodeCommunicationMode, andresourceTagsin commandsaz batch pool showandaz batch pool list.History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.