Conversation
…z storage account or-policy create/update`
calvinhzy
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account or-policy create | cmd storage account or-policy create added parameter enable_metrics |
||
| storage account or-policy create | cmd storage account or-policy create removed property is_preview |
||
| storage account or-policy delete | cmd storage account or-policy delete removed property is_preview |
||
| storage account or-policy list | cmd storage account or-policy list removed property is_preview |
||
| storage account or-policy rule add | cmd storage account or-policy rule add removed property is_preview |
||
| storage account or-policy rule list | cmd storage account or-policy rule list removed property is_preview |
||
| storage account or-policy rule remove | cmd storage account or-policy rule remove removed property is_preview |
||
| storage account or-policy rule show | cmd storage account or-policy rule show removed property is_preview |
||
| storage account or-policy rule update | cmd storage account or-policy rule update removed property is_preview |
||
| storage account or-policy show | cmd storage account or-policy show removed property is_preview |
||
| storage account or-policy update | cmd storage account or-policy update added parameter enable_metrics |
||
| storage account or-policy update | cmd storage account or-policy update removed property is_preview |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the --enable-metrics flag to the az storage account or-policy create and update commands, allowing users to control whether object replication metrics are enabled for storage account object replication policies. The change also removes the preview flag from the object replication policy commands.
- Add
--enable-metricsparameter to create and update object replication policy commands - Update function signatures and implementation to handle metrics configuration
- Remove preview flags from object replication policy command groups
- Add test coverage for the new metrics functionality
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| _params.py | Adds the --enable-metrics argument definition with help text |
| account.py | Updates create and update functions to handle the metrics parameter |
| commands.py | Removes preview flags from object replication policy command groups |
| test_storage_account_scenarios.py | Adds test coverage for the new metrics functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+797
to
+798
| c.argument('enable_metrics', arg_type=get_three_state_flag(), | ||
| help='Indicates whether object replication metrics feature is enabled for the policy.') |
There was a problem hiding this comment.
The help message should start with a verb in the imperative voice. Consider changing 'Indicates whether...' to 'Enable or disable object replication metrics for the policy.'
evelyn-ys
approved these changes
Sep 9, 2025
evelyn-ys
changed the title
az storage account or-policy create/update: Add --enable-metricsaz storage account or-policy create/update: Add --enable-metrics to support object replication metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Storage]
az storage account or-policy create/update: Add--enable-metricsto support object replication metricsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.