Skip to content

[AKS] az aks create: Fix the issue where enabling v1 container storage does not fail if the VM SKU field is left empty #32109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 2 commits into from
Sep 17, 2025
Merged

[AKS] az aks create: Fix the issue where enabling v1 container storage does not fail if the VM SKU field is left empty #32109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
936acfb
[AKS] az aks create: Fix minor issue with --enable-azure-container-st…
nearora-msft Sep 12, 2025
8a942fe
Minor formatting changes
nearora-msft Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ def _validate_nodepools( # pylint: disable=too-many-branches,too-many-locals
'and retry the Azure Container Storage operation.'
)
vm_size = agentpool.get("vm_size")
if vm_size is not None:
if vm_size is not None and vm_size != "":
cpu_value, nvme_enabled = get_vm_sku_details(vm_size.lower())
if cpu_value is None or nvme_enabled is None:
raise UnknownError(
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8825,7 +8825,7 @@ def update_azure_container_storage(self, mc: ManagedCluster) -> ManagedCluster:
except Exception as ex:
raise UnknownError(
f"An error occurred while checking the version of Azure Container Storage"
f"extension installed on the cluster: {str(ex)}"
f" extension installed on the cluster: {str(ex)}"
) from ex

disable_azure_container_storage_v1 = disable_azure_container_storage_param is not None and is_container_storage_v1_extension_installed
Expand Down
Loading