Skip to content

[App Service] az functionapp create: Add the --domain-name-scope support #32110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 7 commits into from
Sep 22, 2025
Merged

[App Service] az functionapp create: Add the --domain-name-scope support #32110

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40d6a02
added unique domain feature in functionapp create
khkh-ms May 5, 2025
3e526e8
updated the tests
khkh-ms Jun 11, 2025
f0929bf
Updated tests
khkh-ms Jul 9, 2025
450a30a
updating the tests
khkh-ms Sep 16, 2025
919955f
reset .gitignore
khkh-ms Sep 18, 2025
3cafdae
changed back SiteConfig instance creation
khkh-ms Sep 18, 2025
8124304
revert the skip
khkh-ms Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ __pycache__/
# Virtual environment
env/
env27/
ienv/
iienv/
iiienv/
vvenv/
Copy link
Copy Markdown
Contributor

@yanzhudd yanzhudd Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why need to modify .gitignore file?

Copy link
Copy Markdown
Contributor Author

@khkh-ms khkh-ms Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

venv/
.python-version

Expand Down
1 change: 1 addition & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,7 @@ def load_arguments(self, _):
help='Enable zone redundancy for high availability. Applies to Flex Consumption SKU only.', is_preview=True)
c.argument('configure_networking_later', options_list=['--configure-networking-later', '--cnl'], arg_type=get_three_state_flag(),
help='Use this option if you want to configure networking later for an app using network-restricted storage.')
c.argument('auto_generated_domain_name_label_scope', options_list=['--domain-name-scope'], help="Specify the scope of uniqueness for the default hostname during resource creation. ", choices=['TenantReuse', 'SubscriptionReuse', 'ResourceGroupReuse', 'NoReuse'])
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help message should start with an active voice verb instead of "Specify". Consider changing to "Set the scope of uniqueness for the default hostname during resource creation."

Copilot uses AI. Check for mistakes.

with self.argument_context('functionapp deployment config set') as c:
c.argument('deployment_storage_name', options_list=['--deployment-storage-name', '--dsn'], help="The deployment storage account name.", is_preview=True)
Expand Down
9 changes: 6 additions & 3 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6092,7 +6092,8 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non
always_ready_instances=None, maximum_instance_count=None, instance_memory=None,
flexconsumption_location=None, deployment_storage_name=None,
deployment_storage_container_name=None, deployment_storage_auth_type=None,
deployment_storage_auth_value=None, zone_redundant=False, configure_networking_later=None):
deployment_storage_auth_value=None, zone_redundant=False, configure_networking_later=None,
auto_generated_domain_name_label_scope=None):
# pylint: disable=too-many-statements, too-many-branches

if functions_version is None and flexconsumption_location is None:
Expand Down Expand Up @@ -6184,7 +6185,8 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non

disable_app_insights = disable_app_insights == "true"

site_config = SiteConfig(app_settings=[])
settings = []
site_config = SiteConfig(app_settings=settings)
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The introduction of an intermediate settings variable that's immediately used once adds unnecessary complexity. The original direct initialization SiteConfig(app_settings=[]) was clearer and more concise.

Suggested change
settings = []
site_config = SiteConfig(app_settings=settings)
site_config = SiteConfig(app_settings=[])

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@kamperiadis kamperiadis Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khkh-ms can you provide more context on why this change was made? I don't see where we use that settings variable elsewhere

Copy link
Copy Markdown
Contributor Author

@khkh-ms khkh-ms Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back. Don't remember but had probably changed it for testing.

client = web_client_factory(cmd.cli_ctx)

if vnet or subnet:
Expand Down Expand Up @@ -6224,7 +6226,8 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non
site_config.http20_proxy_flag = None

functionapp_def = Site(location=None, site_config=site_config, tags=tags,
virtual_network_subnet_id=subnet_resource_id, https_only=https_only)
virtual_network_subnet_id=subnet_resource_id, https_only=https_only,
auto_generated_domain_name_label_scope=auto_generated_domain_name_label_scope)

plan_info = None
if runtime is not None:
Expand Down
Loading