Skip to content

[AppService] Fix #32044: az functionapp deployment source config-zip: Fix uploaded blob not containing content #32119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinhzy merged 2 commits into from
Sep 16, 2025
Merged

[AppService] Fix #32044: az functionapp deployment source config-zip: Fix uploaded blob not containing content #32119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ef7fb2
fix `az functionapp deployment source config-zip` uploaded blob only …
calvinhzy Sep 15, 2025
1a44ceb
style
calvinhzy Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,7 +1666,12 @@ def progress_callback(current, total):
progress_message = 'Uploading {} {}%'.format(progress_bar, percents)
cmd.cli_ctx.get_progress_controller().add(message=progress_message)

blob_client = container_client.upload_blob(blob_name, src, validate_content=True, progress_hook=progress_callback)
blob_client = None
import os
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import os statement should be moved to the top of the file with other imports rather than being placed within the function. This follows Python best practices for import organization.

Copilot uses AI. Check for mistakes.
with open(os.path.realpath(os.path.expanduser(src)), 'rb') as fs:
zip_content = fs.read()
blob_client = container_client.upload_blob(blob_name, zip_content, validate_content=True,
progress_hook=progress_callback)
Comment on lines +1669 to +1674
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable blob_client = None initialization on line 1669 is unnecessary since blob_client is immediately assigned a value within the with statement context.

Copilot uses AI. Check for mistakes.

now = datetime.datetime.utcnow()
blob_start = now - datetime.timedelta(minutes=10)
Expand Down