[App Service] az webapp config appsettings set: Fix SyntaxWarning invalid decimal literal#32136
Merged
[App Service] az webapp config appsettings set: Fix SyntaxWarning invalid decimal literal#32136
az webapp config appsettings set: Fix SyntaxWarning invalid decimal literal#32136Conversation
Fixes Azure#32084 When using 'az webapp config appsettings set' with values like 'TestKey=6in', users were seeing SyntaxWarning: invalid decimal literal. This was happening because the code was trying to parse simple key=value pairs through ast.literal_eval(), which interprets '6in' as an invalid numeric literal. The fix adds a fast-path for simple key=value pairs that avoids calling shell_safe_json_parse (and thus ast.literal_eval) when the input clearly looks like a simple assignment rather than JSON or Python dict syntax. Changes: - Added detection for simple key=value patterns - Parse them directly with split() to avoid ast.literal_eval warnings - Preserve existing functionality for JSON and file input (@file) - Fall back to original parsing logic for complex cases Tested with values like 'TestKey=6in', 'AnotherKey=7in' that previously caused warnings. The fix eliminates the warnings while maintaining full compatibility with existing JSON and file-based input methods.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a SyntaxWarning issue in the az webapp config appsettings set command that was causing false-positive error messages when setting simple key=value pairs. The fix adds early detection for basic key=value syntax to avoid unnecessary JSON parsing that triggered warnings.
- Adds pre-validation logic to handle simple key=value pairs without invoking JSON parsing
- Updates help text for container webhook URL command to clarify Basic Auth requirement
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/appservice/custom.py | Adds early parsing for simple key=value pairs to avoid SyntaxWarning from JSON parser |
| src/azure-cli/azure/cli/command_modules/appservice/_help.py | Updates help text to clarify Basic Auth requirement for webhook URL |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
seligj95
changed the title
az webapp config appsettings set: Fix SyntaxWarning: invalid decimal literalaz webapp config appsettings set: Fix SyntaxWarning invalid decimal literal
yanzhudd
approved these changes
Sep 29, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp config appsettings set
az webapp deployment container show-cd-url
Description
Validation was causing false-positive error message to be displayed in command output. Updated logic to only validate when needed.
Also updated help text for an unrelated command.
Fixes: #32097
Fixes: #32084
Testing Guide
az webapp config appsettings set -n -g --settings TestKey=6in --> should not display SyntaxWarning anymore
az webapp deployment container show-cd-url -n -g --> help text updated to make it clear that Basic Auth needs to be enabled in order to view the un-redacted URL
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.