{Keyvault} Support ip rules for MHSM#32142
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| keyvault network-rule add | cmd keyvault network-rule add added parameter hsm_name |
||
| keyvault network-rule add | cmd keyvault network-rule add update parameter vault_name: removed property required=True |
||
| keyvault network-rule list | cmd keyvault network-rule list added parameter hsm_name |
||
| keyvault network-rule list | cmd keyvault network-rule list update parameter vault_name: removed property required=True |
||
| keyvault network-rule remove | cmd keyvault network-rule remove added parameter hsm_name |
||
| keyvault network-rule remove | cmd keyvault network-rule remove update parameter vault_name: removed property required=True |
||
| keyvault network-rule wait | cmd keyvault network-rule wait added parameter hsm_name |
||
| keyvault network-rule wait | cmd keyvault network-rule wait update parameter vault_name: removed property required=True |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds IP network rule management support for Azure Key Vault Managed HSM (MHSM) resources, extending existing functionality that was previously available only for Key Vault resources.
- Adds IP rule configuration support for MHSM creation via
az keyvault create --hsm-namewith--network-acls-ips - Extends
az keyvault network-rule add/remove/list/waitcommands to support MHSM resources with--hsm-nameparameter - Updates SDK dependencies to version 12.1.0 to support new MHSM IP rule functionality
Reviewed Changes
Copilot reviewed 17 out of 30 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updates azure-mgmt-keyvault dependency to version 12.1.0 |
| requirements.py3.*.txt | Updates azure-mgmt-keyvault dependency across all platform requirement files |
| _params.py | Adds hsm_name parameter support to network-rule commands |
| commands.py | Updates network-rule commands to use new vault-or-hsm functions and custom wait command |
| custom.py | Implements MHSM IP rule management functions and updates existing commands to support both vault and HSM |
| _help.py | Updates help text to reflect support for both vault and managed HSM |
| test_keyvault_commands.py | Adds comprehensive test coverage for MHSM network rule functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evelyn-ys
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
evelyn-ys
requested review from
kairu-ms,
necusjz and
wangzelin007
as code owners
Member
Author
|
@microsoft-github-policy-service rerun |
kairu-ms
approved these changes
Sep 24, 2025
zhoxing-ms
approved these changes
Sep 24, 2025
calvinhzy
approved these changes
Sep 24, 2025
jsntcy
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az keyvault createaz keyvault network-rule add/remove/list/waitDescription
Similar with vault, managed hsm now allows managing ip rules as well.
This PR adds ip rule management support for
az keyvault create --hsm-namewith--network-acls-ipsaz keyvault network-rule add/remove --hsm-namewith--ip-addressaz keyvault network-rule list --hsm-namePR relies on SDK release https://github.com/Azure/sdk-release-request/issues/6578
Testing Guide
Check the added scenario test
History Notes
[Keyvault]
az keyvault create: Support--network-acls-ipswhile creating Managed HSM[Keyvault]
az keyvault network-rule add/remove/list/wait: Support ip rule configuration for Managed HSMThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.