Skip to content

{Keyvault} Support ip rules for MHSM #32142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 16 commits into from
Sep 24, 2025
Merged

{Keyvault} Support ip rules for MHSM #32142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
29449d5
Upgrade API version for keyvault and mhsm
evelyn-ys Sep 10, 2025
cacb94f
add ip rule
evelyn-ys Sep 11, 2025
678ea6c
remove/list network rules
evelyn-ys Sep 15, 2025
24bd429
Add help
evelyn-ys Sep 15, 2025
238e651
add test
evelyn-ys Sep 18, 2025
fa7b5b9
typo
evelyn-ys Sep 19, 2025
589c898
Merge remote-tracking branch 'upstream/dev' into mhsm_ip_rules
evelyn-ys Sep 22, 2025
341955b
Rerun tests from instance 4. See test_results_None_latest_4.parallel.…
azclibot Sep 22, 2025
be67c30
Rerun tests from instance 7. See test_results_None_latest_7.parallel.…
azclibot Sep 22, 2025
33c38cf
Rerun tests from instance 6. See test_results_None_latest_6.parallel.…
azclibot Sep 22, 2025
c5b5ab2
Rerun tests from instance 1. See test_results_None_latest_1.serial.xm…
azclibot Sep 22, 2025
5cbc528
Rerun tests from instance 2. See test_results_None_latest_2.parallel.…
azclibot Sep 22, 2025
29cc165
test recordings in other modules
evelyn-ys Sep 23, 2025
16491ee
fix style
evelyn-ys Sep 23, 2025
158cfdd
remove unused argument
evelyn-ys Sep 23, 2025
dc59930
fix
evelyn-ys Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ings/test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 (DOCKER) azsdk-python-core/1.31.0 Python/3.12.3 (Linux-6.8.0-1026-azure-x86_64-with-glibc2.38)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2024-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2025-05-01
response:
body:
string: '{"error":{"code":"ResourceNotFound","message":"The Resource ''Microsoft.KeyVault/vaults/cliakstestkv000002''
Expand Down Expand Up @@ -70,7 +70,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 (DOCKER) azsdk-python-core/1.31.0 Python/3.12.3 (Linux-6.8.0-1026-azure-x86_64-with-glibc2.38)
method: PUT
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2024-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2025-05-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002","name":"cliakstestkv000002","type":"Microsoft.KeyVault/vaults","location":"westus2","tags":{},"systemData":{"createdBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","createdByType":"Application","createdAt":"2025-04-17T22:47:38.455Z","lastModifiedBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","lastModifiedByType":"Application","lastModifiedAt":"2025-04-17T22:47:38.455Z"},"properties":{"sku":{"family":"A","name":"standard"},"tenantId":"72f988bf-86f1-41af-91ab-2d7cd011db47","accessPolicies":[],"enabledForDeployment":false,"enableSoftDelete":true,"softDeleteRetentionInDays":90,"enableRbacAuthorization":true,"vaultUri":"https://cliakstestkv000002.vault.azure.net","provisioningState":"RegisteringDns","publicNetworkAccess":"Enabled"}}'
Expand Down Expand Up @@ -124,7 +124,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 (DOCKER) azsdk-python-core/1.31.0 Python/3.12.3 (Linux-6.8.0-1026-azure-x86_64-with-glibc2.38)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2024-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2025-05-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002","name":"cliakstestkv000002","type":"Microsoft.KeyVault/vaults","location":"westus2","tags":{},"systemData":{"createdBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","createdByType":"Application","createdAt":"2025-04-17T22:47:38.455Z","lastModifiedBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","lastModifiedByType":"Application","lastModifiedAt":"2025-04-17T22:47:38.455Z"},"properties":{"sku":{"family":"A","name":"standard"},"tenantId":"72f988bf-86f1-41af-91ab-2d7cd011db47","accessPolicies":[],"enabledForDeployment":false,"enableSoftDelete":true,"softDeleteRetentionInDays":90,"enableRbacAuthorization":true,"vaultUri":"https://cliakstestkv000002.vault.azure.net/","provisioningState":"RegisteringDns","publicNetworkAccess":"Enabled"}}'
Expand Down Expand Up @@ -174,7 +174,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 (DOCKER) azsdk-python-core/1.31.0 Python/3.12.3 (Linux-6.8.0-1026-azure-x86_64-with-glibc2.38)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2024-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2025-05-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002","name":"cliakstestkv000002","type":"Microsoft.KeyVault/vaults","location":"westus2","tags":{},"systemData":{"createdBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","createdByType":"Application","createdAt":"2025-04-17T22:47:38.455Z","lastModifiedBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","lastModifiedByType":"Application","lastModifiedAt":"2025-04-17T22:47:38.455Z"},"properties":{"sku":{"family":"A","name":"standard"},"tenantId":"72f988bf-86f1-41af-91ab-2d7cd011db47","accessPolicies":[],"enabledForDeployment":false,"enableSoftDelete":true,"softDeleteRetentionInDays":90,"enableRbacAuthorization":true,"vaultUri":"https://cliakstestkv000002.vault.azure.net/","provisioningState":"Succeeded","publicNetworkAccess":"Enabled"}}'
Expand Down Expand Up @@ -1530,7 +1530,7 @@ interactions:
User-Agent:
- AZURECLI/2.71.0 (DOCKER) azsdk-python-core/1.31.0 Python/3.12.3 (Linux-6.8.0-1026-azure-x86_64-with-glibc2.38)
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2024-11-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002?api-version=2025-05-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.KeyVault/vaults/cliakstestkv000002","name":"cliakstestkv000002","type":"Microsoft.KeyVault/vaults","location":"westus2","tags":{},"systemData":{"createdBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","createdByType":"Application","createdAt":"2025-04-17T22:47:38.455Z","lastModifiedBy":"705ac000-bf67-4eed-9ba0-9ee723df283a","lastModifiedByType":"Application","lastModifiedAt":"2025-04-17T22:47:38.455Z"},"properties":{"sku":{"family":"A","name":"standard"},"tenantId":"72f988bf-86f1-41af-91ab-2d7cd011db47","accessPolicies":[],"enabledForDeployment":false,"enableSoftDelete":true,"softDeleteRetentionInDays":90,"enableRbacAuthorization":true,"vaultUri":"https://cliakstestkv000002.vault.azure.net/","provisioningState":"Succeeded","publicNetworkAccess":"Enabled"}}'
Expand Down
Loading