Conversation
…ant, using eastus2 instead
…25-01-01 # Conflicts: # src/azure-cli/azure/cli/command_modules/marketplaceordering/tests/latest/test_marketplaceordering_scenario_coverage.md # src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_customer_managed_key.yaml # src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_account_encryption_scope.yaml
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account create | cmd storage account create added parameter enable_smb_oauth |
||
| storage account update | cmd storage account update added parameter enable_smb_oauth |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the --enable-smb-oauth parameter to both az storage account create and az storage account update commands, allowing users to enable or disable SMB OAuth authentication for Azure Files using managed identities.
Changes Summary
- Adds new
--enable-smb-oauthparameter support to storage account create and update commands - Implements the functionality to configure SMB OAuth settings in Azure Files identity-based authentication
- Includes comprehensive test coverage for the new feature
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_storage_account_scenarios.py | Adds comprehensive test cases for SMB OAuth functionality across create/update scenarios |
| test_storage_account_smb_oauth.yaml | Recording file capturing HTTP interactions for the new test cases |
| account.py | Implements the core logic to handle enable_smb_oauth parameter in create/update operations |
| _params.py | Defines the new --enable-smb-oauth parameter for both create and update commands |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_account_scenarios.py:1
- The test creates storage account
sasmboauth4but never uses it in any assertions. This test case appears incomplete and should either include verification checks or be removed.
# --------------------------------------------------------------------------------------------
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evelyn-ys
approved these changes
Sep 26, 2025
calvinhzy
changed the title
az storage account create/update: Support --enable-smb-oauthaz storage account create/update: Support --enable-smb-oauth to allow managed identities to access SMB shares using OAuth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Supported enabling SMB Oauth on Storage accounts
Testing Guide
History Notes
[Storage]
az storage account create/update: Support--enable-smb-oauthto allow managed identities to access SMB shares using OAuthThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.