Conversation
️✔️AzureCLI-FullTest
|
|
Hi @nineela, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Regional Site Name Availability Check for DNL (Domain Name Label) site creations. Instead of using the global Check Name Availability API, the implementation now calls the Regional CNA API when a domain name scope is specified.
- Added
get_regional_site_availabilityfunction to call the regional check name availability API - Modified
create_webappfunction to conditionally use regional check based on domain name scope parameter - Updated test recordings to reflect the new API endpoint and request body format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
custom.py |
Import and conditionally call regional site availability check for DNL scenarios |
_create_util.py |
Implement new regional site availability function with validation logic |
test_webapp_dnl.yaml |
Updated test recordings showing new API endpoint and enhanced request payload |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nineela
changed the title
nineela
changed the title
yanzhudd
changed the title
az webapp create: Include regional site name availability check for DNL site creations
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
@microsoft-github-policy-service rerun |
yanzhudd
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp create --resource-group --plan --name --domain-name-scope <TenantReuse|SubscriptionReuse|ResourceGroupReuse|NoReuse>
Description
For DNL/Regional site creations, instead of using global Check Name Availability API, we should call regional Check Name Availability API. This PR adds a new method which calls the Regional CNA API
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.