[Compute] az disk create/update: Add new parameter --supported-security-option to support setting supported security option #32186
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new parameters to the az disk create and az disk update commands to support additional disk configuration options. The changes enable users to set supported security options for Trusted Launch and Confidential VMs, as well as configure disk availability policies.
- Adds
--supported-security-optionparameter for setting security capabilities (TrustedLaunchSupported, TrustedLaunchAndConfidentialVMSupported) - Adds
--action-on-disk-delayparameter for configuring disk availability policy (AutomaticReattach, None) - Updates AAZ (Auto-generated Azure CLI) files to use the newer 2025-01-02 API version
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Adds test cases for both new parameters testing create and update scenarios |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/ | Test recording files capturing the API interactions for the new functionality |
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Updates the create_managed_disk function to support the new parameters |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/disk/ | Updates AAZ generated files for disk commands to support new API version and parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Related command
az disk create/updateDescription
upgrade disk api version to support new parameters
close #31842
close #31914
AAZ: Azure/aaz#868
Testing Guide
History Notes
[Compute]
az disk create/update: Add new parameter--supported-security-optionto support setting supported security option[Compute]
az disk create/update: Add new parameter--action-on-disk-delayto support setting disk availability policyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.