Conversation
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage file symbolic-link | sub group storage file symbolic-link added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
calvinhzy
requested review from
jiasli,
jsntcy and
zhoxing-ms
as code owners
calvinhzy
requested review from
bebound,
kairu-ms and
necusjz
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Azure multiapi-storage library version from 1.5.0 to 1.6.0 and adds test coverage for NFS fileshare symbolic link functionality, specifically supporting the creation and retrieval of symbolic links in Azure file shares.
Key Changes
- Library version update for enhanced NFS fileshare symbolic link support
- New symbolic link test coverage with metadata, owner, group, and timestamps
- Updated API version references from 2025-05-05 to 2025-07-05
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updates azure-multiapi-storage dependency from 1.5.0 to 1.6.0 |
| src/azure-cli/requirements.py3.*.txt | Updates azure-multiapi-storage version across all platform requirements |
| test_storage_file_scenarios.py | Adds new test case for symbolic link creation and retrieval with NFS fileshare |
| test recordings | Updates recorded test interactions with new API version and timestamps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
necusjz
previously approved these changes
Sep 29, 2025
zhoxing-ms
approved these changes
Sep 29, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
bump api version for fileshare to 2025-07-05
Support NFS fileshare symbolic link
Testing Guide
History Notes
[Storage]
az storage file symoblic-link create/show: Support NFS fileshare symbolic linkThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.