Skip to content

Revert "[ACS] az aks create: Pre-announce --no-ssh-key default behaviour breaking change"#32230

Closed
a0x1ab wants to merge 1 commit intodevfrom
revert-32205-breaking_change
Closed

Revert "[ACS] az aks create: Pre-announce --no-ssh-key default behaviour breaking change"#32230
a0x1ab wants to merge 1 commit intodevfrom
revert-32205-breaking_change

Conversation

@a0x1ab
Copy link
Copy Markdown
Member

@a0x1ab a0x1ab commented Oct 9, 2025

Reverts #32205
[Breaking change to be released in the following iteration]

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

Copilot AI review requested due to automatic review settings October 9, 2025 02:27
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previously added breaking change announcement for az aks create command's SSH key behavior. The revert removes the pre-announcement of a breaking change that would make --no-ssh-key the default behavior when no SSH key parameters are provided.

  • Removes breaking change registration logic for AKS SSH key behavior
  • Cleans up the breaking change announcement file by removing import and registration code
  • Reverts to previous state before the breaking change announcement was added

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

summary="Default SSH key behavior will change. When no SSH key parameters are provided, "
"the command will behave as if '--no-ssh-key' was passed instead of failing"
)
# --------
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete license header comment. The closing line should match the opening format with full dashes.

Suggested change
# --------
# --------------------------------------------------------------------------------------------

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants