Skip to content

{ContainerApp} Replace sharedKey in containerapp test recording #32232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 1 commit into from
Oct 9, 2025
Merged

{ContainerApp} Replace sharedKey in containerapp test recording #32232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ..._modules/containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,7 +1529,7 @@ interactions:
body: '{"location": "eastus", "tags": null, "properties": {"daprAIInstrumentationKey":
null, "vnetConfiguration": null, "appLogsConfiguration": {"destination": "log-analytics",
"logAnalyticsConfiguration": {"customerId": "cb2f0f8a-0cac-482b-970c-19cf5dc99f73",
"sharedKey": "nekELXdh55G+3GKnrGk1vtGFXAbRZq98MnekltFLSfU8+Q0MDxZ/mVfPJjEXTryvn+zyBJMB4fbqN4qcxWqbew=="}},
"sharedKey": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}},
Copy link
Copy Markdown
Contributor

@bebound bebound Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, will this work? Not sure about the detection rule, but it's the same length as the real key.
Maybe try a shorter one?

Copy link
Copy Markdown
Member Author

@evelyn-ys evelyn-ys Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be the same length because we declared the content-length in request header. The regex for sharedKey detection should be complicated so aaa.... should be fine

Copy link
Copy Markdown
Member

@a0x1ab a0x1ab Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credential scanner seems to have passed so I think it's fine: https://github.com/Azure/azure-cli/pull/32232/checks?check_run_id=52313108821

Copy link
Copy Markdown
Contributor

@bebound bebound Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be the same length because we declared the content-length in request header. The regex for sharedKey detection should be complicated so aaa.... should be fine

They're only recordings, no server checks the length mismatch. Could you please push this branch to main repo to verify whether this fixes the credential scanner?

Credential scanner seems to have passed so I think it's fine: https://github.com/Azure/azure-cli/pull/32232/checks?check_run_id=52313108821

This task is skipped in PR: Guardian is not supported for builds from forked GitHub repositories. Current Guardian Task will be skipped

"customDomainConfiguration": null, "workloadProfiles": [{"workloadProfileType":
"Consumption", "Name": "Consumption"}], "zoneRedundant": false}}'
headers:
Expand Down