[Container App] az containerapp env: Add http-route-config and premium-ingress#32240
[Container App] az containerapp env: Add http-route-config and premium-ingress#32240
az containerapp env: Add http-route-config and premium-ingress#32240Conversation
Tratcher
requested review from
Greedygre,
Juliehzl,
howang-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env http-route-config | sub group containerapp env http-route-config added |
||
| containerapp env premium-ingress | sub group containerapp env premium-ingress added |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two new command groups for Azure Container Apps environments: http-route-config and premium-ingress. These commands were previously available in CLI extensions and are now being promoted to GA status in the main CLI.
Key changes:
- Added HTTP route configuration management commands for environment-level request routing
- Added premium ingress configuration commands for enhanced ingress settings
- Added comprehensive test coverage for both command groups
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| utils.py | Added helper function for creating VNet subnets in tests |
| test_containerapp_env_http_route_config.py | New test file for HTTP route configuration CRUD operations |
| test_containerapp_commands.py | Added tests for premium ingress commands |
| custom.py | Implemented business logic for both HTTP route config and premium ingress operations |
| commands.py | Registered new command groups and their subcommands |
| _params.py | Added parameter definitions for both command groups |
| _help.py | Added comprehensive help documentation for all new commands |
| _clients.py | Added HttpRouteConfigClient for API interactions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| helps['containerapp env http-route-config list'] = """ | ||
| type: command | ||
| short-summary: List the http route configs in the environment. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'List the http route configs' to 'List http route configs'.
| helps['containerapp env http-route-config create'] = """ | ||
| type: command | ||
| short-summary: Create a new http route config. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Create a new http route config' to 'Create http route config'.
| helps['containerapp env http-route-config update'] = """ | ||
| type: command | ||
| short-summary: Update a http route config. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Update a http route config' to 'Update http route config'.
| helps['containerapp env http-route-config show'] = """ | ||
| type: command | ||
| short-summary: Show a http route config. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Show a http route config' to 'Show http route config'.
| helps['containerapp env http-route-config delete'] = """ | ||
| type: command | ||
| short-summary: Delete a http route config. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Delete a http route config' to 'Delete http route config'.
| helps['containerapp env premium-ingress show'] = """ | ||
| type: command | ||
| short-summary: Show the premium ingress settings for the environment. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Show the premium ingress settings' to 'Show premium ingress settings'.
| helps['containerapp env premium-ingress add'] = """ | ||
| type: command | ||
| short-summary: Enable the premium ingress settings for the environment. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Enable the premium ingress settings' to 'Enable premium ingress settings'.
| helps['containerapp env premium-ingress update'] = """ | ||
| type: command | ||
| short-summary: Update the premium ingress settings for the environment. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Update the premium ingress settings' to 'Update premium ingress settings'.
| helps['containerapp env premium-ingress remove'] = """ | ||
| type: command | ||
| short-summary: Remove the ingress settings and restores the system to default values. |
There was a problem hiding this comment.
The help message should start with an active voice verb. Change 'Remove the ingress settings and restores' to 'Remove ingress settings and restore'.
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007 and
yonzhan
Tratcher
changed the title
Tratcher
changed the title
az containerapp env: Add http-route-config and premium-ingress
|
It is better to include more details in the history notes section, as it will be shown in the release notes. |
| handle_raw_exception(e) | ||
|
|
||
|
|
||
| def update_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name=None, min_replicas=None, max_replicas=None, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False): |
There was a problem hiding this comment.
Related command
az containerapp env http-route-config
az containerapp env premium-ingress
Description
These commands were previously available in cli-extensions and now the features are ready for GA.
History Notes
[Container App]
az containerapp env http-route-config: Add command group to manage environment level http routing[Container App]
az containerapp env premium-ingress: Add command group to configure premium ingress settings for the environmentThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.