Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys and
yonzhan
calvinhzy
changed the title
az storage file list: Fix file list for nfs shares, as --include is not supportedaz storage file list: Fix file list for nfs shares, as --include is not supported
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the az storage file list command where the --include parameter was being used with NFS file shares, which don't support this parameter. The fix adds logic to check the share protocol type and only includes extended file information for SMB shares.
Key changes:
- Modified
list_share_filesfunction to check share protocol type before settingincludeparameter - Added test coverage for file listing on NFS shares
- Updated test recordings to reflect the new behavior
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/storage/operations/file.py | Added protocol check logic to conditionally set include parameter based on share type (SMB vs NFS) |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_file_scenarios.py | Added test assertions to verify file listing works correctly for NFS shares |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_file_share_nfs_scenario.yaml | Added test recordings for new NFS file list operations |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_file_main_scenario.yaml | Updated test recordings to reflect share properties check before file listing |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_file_main_oauth_scenario.yaml | Updated test recordings to reflect share properties check before file listing with OAuth authentication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| include = [] if exclude_extended_info else ["timestamps", "Etag", "Attributes", "PermissionKey"] | ||
| include = None | ||
| share_properties = client.get_share_properties() | ||
| if share_properties.protocols == ['SMB']: |
There was a problem hiding this comment.
The protocol comparison share_properties.protocols == ['SMB'] may fail if the protocols list contains multiple values or is in a different order. Consider using 'SMB' in share_properties.protocols for more robust protocol checking.
Suggested change
| if share_properties.protocols == ['SMB']: | |
| if 'SMB' in share_properties.protocols: |
evelyn-ys
reviewed
Oct 20, 2025
| include = None | ||
| share_properties = client.get_share_properties() | ||
| if share_properties.protocols == ['SMB']: | ||
| include = [] if exclude_extended_info else ["timestamps", "Etag", "Attributes", "PermissionKey"] |
Member
There was a problem hiding this comment.
Shall we warn/error out for nfs shares when exclude_extended_info is specified?
evelyn-ys
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Previously smb file shares support --include, the new nfs shares do not, so checking the share type before listing.
Testing Guide
History Notes
[Storage]
az storage file list: Fix file list for nfs shares, as--includeis not supportedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.