Skip to content

[Storage] az storage file list: Fix file list for nfs shares, as --include is not supported #32268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinhzy merged 4 commits into from
Oct 24, 2025
Merged

[Storage] az storage file list: Fix file list for nfs shares, as --include is not supported #32268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a3e55c
fix nfs file list, as --include is not supported
calvinhzy Oct 16, 2025
1c55b42
rerun tests
calvinhzy Oct 16, 2025
eb15da7
add check for --exclude-extended-info with nfs file share
calvinhzy Oct 20, 2025
b05a6d3
Merge remote-tracking branch 'upstream/dev' into storage-file-list-nf…
calvinhzy Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/azure-cli/azure/cli/command_modules/storage/operations/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,13 @@ def create_file_url(client, protocol=None, **kwargs):
def list_share_files(cmd, client, directory_name=None, timeout=None, exclude_dir=False, exclude_extended_info=False,
num_results=None, marker=None):
from ..track2_util import list_generator
include = [] if exclude_extended_info else ["timestamps", "Etag", "Attributes", "PermissionKey"]
include = None
share_properties = client.get_share_properties()
if share_properties.protocols == ['SMB']:
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol comparison share_properties.protocols == ['SMB'] may fail if the protocols list contains multiple values or is in a different order. Consider using 'SMB' in share_properties.protocols for more robust protocol checking.

Suggested change
if share_properties.protocols == ['SMB']:
if 'SMB' in share_properties.protocols:

Copilot uses AI. Check for mistakes.
include = [] if exclude_extended_info else ["timestamps", "Etag", "Attributes", "PermissionKey"]
Copy link
Copy Markdown
Member

@evelyn-ys evelyn-ys Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we warn/error out for nfs shares when exclude_extended_info is specified?

elif share_properties.protocols == ['NFS']:
if exclude_extended_info:
logger.warning('--exclude-extended-info is not supported for NFS shares.')
generator = client.list_directories_and_files(directory_name=directory_name, include=include,
timeout=timeout, results_per_page=num_results)
pages = generator.by_page(continuation_token=marker)
Expand Down
Loading