Conversation
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #32107 where az containerapp registry show command throws a NoneType error when the --server parameter specifies a non-existent registry server. The fix adds proper validation to handle empty or null registry configurations.
Key Changes:
- Adds validation to check for null or empty registry definitions before iterating
- Adds test coverage to verify the fix handles non-existent registry servers correctly
- Removes duplicate
@live_only()decorator from existing test
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| custom.py | Adds null/empty check for registry definitions to prevent NoneType errors |
| test_containerapp_scenario.py | Adds test case for non-existent registry server and cleans up duplicate decorator |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Greedygre
changed the title
az containerapp registry show: Fix NoneType error when --server specifies a non-existent registry serveraz containerapp registry show: Fix NoneType error when container app doesn't have registry server
Greedygre
changed the title
az containerapp registry show: Fix NoneType error when container app doesn't have registry serveraz containerapp registry show: Fix NoneType error when container app doesn't have any registry server
Juliehzl
reviewed
Oct 16, 2025
Juliehzl
approved these changes
Oct 17, 2025
Contributor
|
@microsoft-github-policy-service rerun |
yanzhudd
approved these changes
Oct 17, 2025
SakoPak
pushed a commit
to SakoPak/azure-cli
that referenced
this pull request
Oct 21, 2025
…NoneType error when container app doesn't have any registry server (Azure#32270)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue: #32107
Related command
az containerapp registry show
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.