{Containerapp} Fix Credential Scanner failed#32274
Merged
Conversation
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007 and
yonzhan
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a Credential Scanner security issue by replacing potentially sensitive authentication keys in test recording files with placeholder values.
- Replaces actual
sharedKeyvalues in test recordings with a sanitized placeholder "abc123" - Maintains consistent formatting across all test recording files
- Ensures test recordings don't contain real credentials that could trigger security scanners
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test_containerapp_up_source_with_dockerfile_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_up_image_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_tcp_ingress.yaml | Replaced shared key with placeholder value |
| test_containerapp_get_customdomainverificationid_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_update_custom_domains.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_p2p_traffic_encryption.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_mtls.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_logs_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_internal_only_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_custom_domains.yaml | Replaced shared key with placeholder value |
| test_containerapp_env_certificate_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_custom_domains_e2e.yaml | Replaced shared key with placeholder value |
| test_containerapp_create_with_vnet_yaml.yaml | Replaced shared key with placeholder value |
| test_containerapp_create_with_environment_id.yaml | Replaced shared key with placeholder value |
| test_containerapp_compose_create_environment_to_target_location.yaml | Replaced shared key with placeholder value |
| test_container_app_mount_secret_update_e2e.yaml | Replaced shared key with placeholder value |
| test_container_app_mount_secret_e2e.yaml | Replaced shared key with placeholder value |
| test_container_app_mount_azurefile_e2e.yaml | Replaced shared key with placeholder value |
Comments suppressed due to low confidence (16)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
Seems the CI failed not related to this PR's change: |
bebound
approved these changes
Oct 20, 2025
Member
|
We definitely need a replacer to do this. Otherwise, rerunning these tests will generate valid |
Contributor
Author
Hi @jiasli
|
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
requested changes
Oct 20, 2025
Member
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
Instead of manually replacing keys, can you implementing a test recording replacer to automatically do that?
Contributor
Yes, we need a permanent solution for this. We fixed the same issue before in #32232 |
Contributor
|
Next Tuesday is the code freeze. To unblock the release, shall we merge this PR first? @evelyn-ys @Greedygre will create another PR to add the replacer. |
evelyn-ys
approved these changes
Oct 28, 2025
zhoxing-ms
approved these changes
Oct 28, 2025
Contributor
|
There a new format of credential fixed in #32340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.